Skip to content

[Grafana] Filter channel list by selected source - #259

Open
sylvesterkaczmarek wants to merge 4 commits into
nasa:mainfrom
sylvesterkaczmarek:fix/grafana-channel-source-filter-235
Open

sylvesterkaczmarek wants to merge 4 commits into
nasa:mainfrom
sylvesterkaczmarek:fix/grafana-channel-source-filter-235

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor

Fixes #235.

Filter the Grafana channel list using the currently selected telemetry sources. Channel options now refresh when source selections or template-expanded source values change, and stale asynchronous responses cannot overwrite newer results.

Includes frontend and backend regression coverage for source filtering, clearing filters, template variables, request races, quoted source identifiers, empty identifiers, and database errors.

@YKawesome
YKawesome self-requested a review September 14, 2026 20:58

@YKawesome YKawesome left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned from testing that this will skyrocket the query time of the database especially under load. Could we use the current Grafana panel time range to prevent this?

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor Author

Addressed in 97c8e78: source-filtered channel lookups now carry the active Grafana time range, respect the query time overrides and selected ert/time field, and the backend requires and applies bounded from/to values inside the telemetry EXISTS scan. Added backend and frontend regressions. go test ./pkg/plugin, TypeScript typecheck/lint, and the focused Jest suites (13/13) pass.

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor Author

Thanks for merging current main into the branch. The time-bounded source-filter change is still intact and the current checks are green. Could you re-review when convenient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Grafana] Channels list is not filtered by currently selected source

2 participants