Resolve YAMCS telemetry updates - #265
Open
FarkasJoseph wants to merge 6 commits into
Open
FarkasJoseph wants to merge 6 commits into
FarkasJoseph wants to merge 6 commits into
Conversation
…aults for PluginInfo (F3)
- Make ParameterValue fields optional/defaultable (id, raw_value, eng_value, acquisition_status, monitoring_result, expire_millis) - Maintain per-subscription HashMap<u32, NamedObjectId> for numeric_id resolution - Merge incoming mapping on each message - Resolve numeric_id to name if id is missing - Extract component and name from qualified name in TelemetryRef - Skip unresolved parameters with debug log instead of failing the stream - Fix SourcedTelemetry.source to use instance name instead of filter.source
Split out of a later commit that bundled these alongside unrelated raw packet subscription tests - these two specifically validate the numeric_id resolution fix (ParameterValue with only numericId, mapping resolution), not anything about packet subscription.
FarkasJoseph
force-pushed
the
hermes-yamcs/numeric-id-telemetry-resolution
branch
from
September 16, 2026 00:20
0b2d2f4 to
eeafcbd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage ? 44.05%
=======================================
Files ? 56
Lines ? 4208
Branches ? 0
=======================================
Hits ? 1854
Misses ? 2354
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ParameterValue.id became Option<NamedObjectId> so a value can arrive with only a numeric id before the name mapping resolves it. Fall back to a placeholder string instead of unwrapping.
Both files had new logic with no direct test: convert.rs's handling of an unresolved parameter (id missing, skip it) and the id-resolution lookup in service.rs, which was inlined in the subscription loop. Pulled the lookup out into resolve_param_id so it can be tested on its own, and added tests for it and for yamcs_param_to_hermes's two new outcomes (a resolved value converts, an unresolved one is skipped).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is designed to handle yamcs's compact telemetry messages. Yamcs chooses to send the full parameter name in the first telemetry message; however, later messages only include the numeric parameter ID. This PR adds a map to remember the parameter names and restore them for incoming telemetry messages. For updates that cannot yet be resolved, Hermes safely ignores them.
This PR also includes a number of compatibility changes which are covered in another PR. Once that one is merged, this one's scope should only be telemetry updates.