Add hermes-yamcs lib target - #272
Open
FarkasJoseph wants to merge 3 commits into
Open
FarkasJoseph wants to merge 3 commits into
FarkasJoseph wants to merge 3 commits into
Conversation
…aults for PluginInfo (F3)
CI's build-rust-crates.yml only runs 'cargo test --workspace --all-features --lib', which never exercises a bin-only crate's #[cfg(test)] modules. This crate has been bin-only, so every unit test in it has been silently skipped. Add src/lib.rs re-exporting the existing modules, make main.rs a thin binary over the library. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI runs
cargo test --workspace --all-features --lib, but hermes-yamcs is currently bin-only, so any test added to it passes locally but is silently skipped in CI.This PR adds a lib.rs re-exporting the existing modules and makes main.rs a thin binary over it.
This PR also includes the compatibility changes from #264, which will disappear from the diff once that merges.