Skip to content

Entrypoints call ops - #177

Merged
glass-ships merged 8 commits into
reduction-rewritefrom
entrypoints-call-ops
Aug 27, 2026
Merged

Entrypoints call ops#177
glass-ships merged 8 commits into
reduction-rewritefrom
entrypoints-call-ops

Conversation

@glass-ships

@glass-ships glass-ships commented Aug 12, 2026

Copy link
Copy Markdown
Member

Description of work:

Entrypoints now call operation stubs directly.
Some tweaks to fix tests and make arguments ordered consistently.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@ktactac
ktactac changed the base branch from next to reduction-rewrite August 12, 2026 17:33
@codecov-commenter

codecov-commenter commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.87500% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.30%. Comparing base (c6ec650) to head (4d70bf5).

Files with missing lines Patch % Lines
src/lr_reduction/io/yaml.py 57.14% 3 Missing ⚠️
src/lr_reduction/api/manual.py 95.91% 2 Missing ⚠️
src/lr_reduction/api/_single_run.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           reduction-rewrite     #177      +/-   ##
=====================================================
+ Coverage              51.64%   54.30%   +2.66%     
=====================================================
  Files                     59       60       +1     
  Lines                   3799     3887      +88     
=====================================================
+ Hits                    1962     2111     +149     
+ Misses                  1837     1776      -61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/lr_reduction/api/_shared.py Outdated
Comment thread src/lr_reduction/api/interfaces.py Outdated
Comment thread src/lr_reduction/io/orso.py
Comment thread PLACEHOLDER_FILENAME.ort Outdated
Comment thread src/lr_reduction/api/_single_run.py Outdated
Comment thread src/lr_reduction/api/_single_run.py Outdated
Comment thread src/lr_reduction/api/manual.py Outdated
Comment thread src/lr_reduction/api/_single_run.py Outdated
Comment thread src/lr_reduction/api/autoreduce.py Outdated
Comment thread src/lr_reduction/api/manual.py Outdated
Comment thread src/lr_reduction/api/manual.py Outdated
Comment thread src/lr_reduction/api/manual.py Outdated
Comment thread docs/source/user/configuration.md Outdated
Comment thread src/lr_reduction/io/yaml.py Outdated
Comment thread src/lr_reduction/types.py Outdated
Comment thread src/lr_reduction/api/live.py
@glass-ships
glass-ships merged commit 4eb72a1 into reduction-rewrite Aug 27, 2026
7 checks passed
@glass-ships
glass-ships deleted the entrypoints-call-ops branch August 27, 2026 15:36
Comment thread src/lr_reduction/api/autoreduce.py
Comment thread src/lr_reduction/api/manual.py
# Validate_sequence_numbers
if self.sequence_numbers is not None:
if len(self.sequence_numbers) != len(self.run_numbers):
raise LrValidationError(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this probably calls for its own class of error. Feels like these entry points could use their own hierarchy of error to keep this sorted

Comment thread src/lr_reduction/api/manual.py
Comment thread src/lr_reduction/api/manual.py
Comment thread tests/unit/api/test_manual.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants