Entrypoints call ops - #177
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## reduction-rewrite #177 +/- ##
=====================================================
+ Coverage 51.64% 54.30% +2.66%
=====================================================
Files 59 60 +1
Lines 3799 3887 +88
=====================================================
+ Hits 1962 2111 +149
+ Misses 1837 1776 -61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ktactac
reviewed
Aug 12, 2026
ktactac
reviewed
Aug 12, 2026
ktactac
reviewed
Aug 12, 2026
ktactac
reviewed
Aug 12, 2026
ktactac
approved these changes
Aug 12, 2026
backmari
reviewed
Aug 13, 2026
backmari
reviewed
Aug 14, 2026
ktactac
reviewed
Aug 26, 2026
backmari
reviewed
Aug 27, 2026
backmari
reviewed
Aug 27, 2026
backmari
reviewed
Aug 27, 2026
backmari
approved these changes
Aug 27, 2026
ktactac
reviewed
Aug 27, 2026
| # Validate_sequence_numbers | ||
| if self.sequence_numbers is not None: | ||
| if len(self.sequence_numbers) != len(self.run_numbers): | ||
| raise LrValidationError( |
Collaborator
There was a problem hiding this comment.
i think this probably calls for its own class of error. Feels like these entry points could use their own hierarchy of error to keep this sorted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work:
Entrypoints now call operation stubs directly.
Some tweaks to fix tests and make arguments ordered consistently.
Check all that apply:
updated documentationAdded unit testsAdded integration testsVerified that tests requiring the /SNS and /HFIR filesystems pass without failReferences:
(Instructions for testing here)
Check list for the reviewer