Skip to content

fix: adding sort for db out of order - #179

Merged
welbournR merged 1 commit into
expfrom
db-ordering
Aug 17, 2026
Merged

fix: adding sort for db out of order#179
welbournR merged 1 commit into
expfrom
db-ordering

Conversation

@welbournR

Copy link
Copy Markdown
Collaborator

In the direct beam maker script the runs are now first sorted according to the Cd thickness before processing. This allows a consistent approach irrespective of which order they are measured. It also allows the flag for a different dead time correction to be applied to the largest Cd/lowest TOF dataset consistently.
It requires a load of the log twice but does not seem to have slowed down the processing.

Description of work:

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@welbournR
welbournR merged commit 83d6671 into exp Aug 17, 2026
3 of 6 checks passed
@welbournR
welbournR deleted the db-ordering branch August 17, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant