Templates are Pro, not cloud-only - #150
Open
nmbrthirteen wants to merge 1 commit into
Open
Conversation
A template belongs to the account, so signing in on a laptop should mean `--template "Bold cuts"` cuts the way the studio cuts. It said nothing of the sort: templates existed only behind the web app, and the CLI had a growing pile of flags with no way to name a set of them. `podcli templates` lists what the account has. `--template` on `process` and `studio` resolves one by name or id and fills the render config from it, before the flags, so anything typed still wins. Signed out, it says templates are Pro and points at the flags, which are the same flags a free render has always taken. Nothing about an offline render changes. That is the boundary: the primitives are core and always will be, and Pro sells the named bundle of them plus the builder that composes it. Which is also why the last two changes went in as flags rather than as a template format in the engine. The rest is the same capabilities reaching the rest of core, since they only landed on `process`: `studio` takes --logo, --name-card and --motion, and the MCP create_clip and batch_create_clips carry name_card, motion and bookend_fade through. And drawing a thumbnail is finally a separate decision from welding it onto the video: --thumbnail-placement off keeps the pictures and leaves the file alone. It defaulted to welding it on because that was the only behaviour there had ever been, and "I want the picture, not in my video" had no answer. Default unchanged.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #149.
A template belongs to the account, so signing in on a laptop should mean
--template "Bold cuts"cuts the way the studio cuts. It didn't: templates existed only behind the web app, and the CLI had a growing pile of flags with no way to name a set of them.The boundary
--caption-style --crop --format --logo --name-card --motion --bookend-fade --thumbnail-placement. Nothing here changes.This is also why the last two PRs landed as flags rather than as a template format in the engine.
What's here
podcli templateslists the account's looks.--template <name|id>onprocessandstudiofills the render config, applied before the flags so anything typed still wins. Signed out it says templates are Pro and points at the flags.Verified against a real API with a Pro token: resolves by name and by id, fills crop / format / caption style / the default logo asset / thumbnail behaviour.
The rest of core catches up
The capabilities from #148 and #149 only landed on
process. Now:studiotakes--logo,--name-card,--name-card-sub,--name-card-seconds,--motioncreate_clipandbatch_create_clipscarryname_card,motionandbookend_fadeDrawing a thumbnail is no longer the same decision as welding it on
--thumbnail-placement offkeeps the pictures and leaves the video alone. It has only ever done both, so "I want the picture, not in my video" had no answer. The default is unchanged (start).