Skip to content

lookup: remove JSONStream - #1114

Open
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:remove/jsonstream
Open

lookup: remove JSONStream#1114
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:remove/jsonstream

Conversation

@MikeMcC399

Copy link
Copy Markdown

Situation

JSONStream is deprecated and unsupported. It cannot therefore fulfil the Hard Requirements:

The maintainers of the module remain responsive when there are problems

Item Status
npm package https://www.npmjs.com/package/JSONStream
npm status deprecated
last published 1.3.5 Oct 14, 2018
repo location https://github.com/dominictarr/JSONStream
repo status archived on Dec 4, 2018
lookup maintainer(s) dominictarr

https://github.com/dominictarr/JSONStream archived Dec 4, 2018

Change

Remove JSONStream from lib/lookup.json

Checklist
  • npm test passes
  • contribution guidelines followed
    here

cc: @dominictarr

@codecov-commenter

codecov-commenter commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (ff3ea4a) to head (f89d79f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1114   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files          29       29           
  Lines        2203     2203           
=======================================
  Hits         2126     2126           
  Misses         77       77           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399

MikeMcC399 commented Aug 4, 2026

Copy link
Copy Markdown
Author

This package fails in citgm under npm@12 since one of its devDependencies transient dependencies fomatto@0.5.0, published 15 years ago, is type git.

Steps to reproduce

On Ubuntu 24.04.4 LTS, Node.js 24.19.0

npm install -g npm@12.0.2
npm install -g citgm@10.0.2 --allow-scripts=yarn
citgm JSONStream

Logs

$ citgm JSONStream
info: starting            | JSONStream
info: lookup              | JSONStream
info: lookup-found        | JSONStream
info: JSONStream lookup-replace| https://github.com/dominictarr/JSONStream/archive/0593d4b4e6c63c6c0e2e68463538fd83bd1eb964.tar.gz
info: JSONStream npm:     | Downloading project: https://github.com/dominictarr/JSONStream/archive/0593d4b4e6c63c6c0e2e68463538fd83bd1eb96
info: JSONStream npm:     | Project downloaded 0593d4b4e6c63c6c0e2e68463538fd83bd1eb964.tar.gz
info: JSONStream npm:     | npm install started
warn: JSONStream npm-install:| npm error code EALLOWGIT
warn: JSONStream npm-install:| npm error Fetching packages of type "git" have been disabled
warn:                        | npm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df
warn: JSONStream npm-install:| npm error A complete log of this run can be found in: /tmp/720dcdf6/home/.npm/_logs/2026-08-04T14_49_01_252
error: failure             | Install Failed
error: failing module(s)   |
error: module name:        | JSONStream
error: version:            | 1.3.5
error: error:              | Install Failed
error: error:              | undefined
error:                     | npm error code EALLOWGIT
error:                     | npm error Fetching packages of type "git" have been disabled
error:                     | npm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428
error:                     | npm error A complete log of this run can be found in: /tmp/720dcdf6/home/.npm/_logs/2026-08-04T14_49_01_252Z-d
error: done                | The smoke test has failed.
info: duration            | test duration: 6657ms

Alternative steps

git clone https://github.com/dominictarr/JSONStream
cd JSONStream
npm install

Logs

$ git clone https://github.com/dominictarr/JSONStream
cd JSONStream
npm install
Cloning into 'JSONStream'...
remote: Enumerating objects: 769, done.
remote: Total 769 (delta 0), reused 0 (delta 0), pack-reused 769 (from 1)
Receiving objects: 100% (769/769), 251.24 KiB | 332.00 KiB/s, done.
Resolving deltas: 100% (462/462), done.
npm error code EALLOWGIT
npm error Fetching packages of type "git" have been disabled
npm error Refusing to fetch "fomatto@git://github.com/BonsaiDen/Fomatto.git#468666f600b46f9067e3da7200fd9df428923ea6"
npm error A complete log of this run can be found in: /home/mike/.npm/_logs/2026-08-04T14_50_21_985Z-debug-0.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants