test: stop requiring core.autocrlf=true on windows

[nadalaba]

Some tests on Windows (test\parallel\test-snapshot-typescript) require the repo to be checked-out with the git config core.autocrlf set to true.
However, a lot of users prefer to use modern editors that can handle LF and keep core.autocrlf set to false to minimize headaches.
This PR fixes the tests for them without breaking it for others.

[nodejs-github-bot]

Review requested:

• @nodejs/startup

[aduh95]

Note that we explicitly request it to be set to true:

node/test/README.md

Lines 11 to 12 in f694c3a

	For the tests to run on Windows, be sure to clone Node.js source code with the
	`autocrlf` git config flag set to true.

Can you split this into two PR so this can be reviewed and backported separately?

[nadalaba]

Can you split this into two PR so this can be reviewed and backported separately?

I opened #63118 for the other test.

[github-actions]

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

[nadalaba]

This is still relevant. Waiting for review.

[aduh95]

I think in order to land this, we would need some kind of linter or at least make sure some CI would fail if some test makes incorrect assumption about the autocrlf value

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (9766a67) to head (5d03015).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63102      +/-   ##
==========================================
- Coverage   90.30%   90.30%   -0.01%     
==========================================
  Files         759      759              
  Lines      247629   247629              
  Branches    46677    46692      +15     
==========================================
- Hits       223628   223619       -9     
+ Misses      15470    15461       -9     
- Partials     8531     8549      +18     

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aduh95]

With autocrlf:

Failed tests:
D:\a\node\node\out\Release\node.exe --experimental-vm-modules --max-old-space-size=16 --trace-gc D:\a\node\node\test\es-module\test-vm-source-text-module-leak.js
D:\a\node\node\out\Release\node.exe D:\a\node\node\test\parallel\test-child-process-exec-any-shells-windows.js
D:\a\node\node\out\Release\node.exe D:\a\node\node\test\parallel\test-inspector-wait-for-connection.js
D:\a\node\node\out\Release\node.exe D:\a\node\node\test\parallel\test-util-getcallsites-sourcemap.js

Without autocrlf:

Failed tests:
D:\a\node\node\out\Release\node.exe --experimental-vm-modules --max-old-space-size=16 --trace-gc D:\a\node\node\test\es-module\test-vm-source-text-module-leak.js
D:\a\node\node\out\Release\node.exe D:\a\node\node\test\parallel\test-child-process-exec-any-shells-windows.js
D:\a\node\node\out\Release\node.exe D:\a\node\node\test\parallel\test-inspector-wait-for-connection.js
D:\a\node\node\out\Release\node.exe D:\a\node\node\test\parallel\test-util-getcallsites-sourcemap.js

But the issue with the coverage job is that it doesn't report test failures, so we would likely still miss regressions

[nadalaba]

@aduh95 Oh, you're right. Sorry about that.
I can move the matrix job to a new test-windows workflow, but the same 4 tests above will fail. Maybe we should put off this step until we fix these tests.
P.S., #63118 will fix one of them

[EDIT]:
I did the move to a new workflow and skipped the only test that always fails (fixable by #63118).
This should be ready now 🤞