test: complete the h2 settings round-trip before asserting single-session multiplexing - #5656
Merged
Merged
Conversation
ostapondo
force-pushed
the
fix-pipelining-test-flake
branch
from
August 5, 2026 20:09
4f8bd65 to
4fe22b1
Compare
…sion multiplexing
ostapondo
force-pushed
the
fix-pipelining-test-flake
branch
from
August 5, 2026 21:21
4fe22b1 to
fe72eef
Compare
Contributor
Author
|
Reopened - closing this was my mistake, the flake is still there. Rebased on main so CodeQL goes green. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5656 +/- ##
==========================================
+ Coverage 93.33% 93.44% +0.10%
==========================================
Files 110 110
Lines 38723 38723
==========================================
+ Hits 36143 36184 +41
+ Misses 2580 2539 -41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fetch POST bodies dispatch concurrently (#5494)test flakes on themacOS runners: sessions.size comes out 2 instead of 1, e.g.
https://github.com/nodejs/undici/actions/runs/30984506686
Over h2 the client counts as busy until the server's SETTINGS frame lands.
With h2c nothing covers that window, so on a slow runner the second fetch
goes out while it is still open and the Agent opens a second connection.
I checked with a TCP proxy that delays server to client by 80ms: no warmup
gives sessions=2 every run, a warmup gives sessions=1 every run.
So warm the session up first, like the SSE test above it does. The #5494
check still works, a client that serialises hangs on
secondArriveduntilthe timeout fires.