ci: only accept a numeric nightly major - #5657
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5657 +/- ##
==========================================
+ Coverage 93.33% 93.44% +0.10%
==========================================
Files 110 110
Lines 38723 38723
==========================================
+ Hits 36143 36184 +41
+ Misses 2580 2539 -41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5654.
The guard I landed there only catches an empty string and the literal
"null". Anything else the download index hands back ends up in
needs.nightly-version.outputs.major, which nodejs-shared.yml drops into agithub-script block. Checking for digits is what it was meant to do.
Ran the check by hand: 27 passes; empty, "null", "8abc" and a string with
quotes in it all fail.