Skip to content

ci: only accept a numeric nightly major - #5657

Merged
mcollina merged 1 commit into
nodejs:mainfrom
ostapondo:ci-nightly-numeric-guard
Aug 5, 2026
Merged

ci: only accept a numeric nightly major#5657
mcollina merged 1 commit into
nodejs:mainfrom
ostapondo:ci-nightly-numeric-guard

Conversation

@ostapondo

@ostapondo ostapondo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #5654.

The guard I landed there only catches an empty string and the literal
"null". Anything else the download index hands back ends up in
needs.nightly-version.outputs.major, which nodejs-shared.yml drops into a
github-script block. Checking for digits is what it was meant to do.

Ran the check by hand: 27 passes; empty, "null", "8abc" and a string with
quotes in it all fail.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 854adb4 into nodejs:main Aug 5, 2026
35 of 37 checks passed
@codecov-commenter

codecov-commenter commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (6aef2fb) to head (9bc4513).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5657      +/-   ##
==========================================
+ Coverage   93.33%   93.44%   +0.10%     
==========================================
  Files         110      110              
  Lines       38723    38723              
==========================================
+ Hits        36143    36184      +41     
+ Misses       2580     2539      -41     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants