fix(cache): settle Cache.add/addAll for responses with a body - #5658
Open
edenbuilds wants to merge 1 commit into
Open
fix(cache): settle Cache.add/addAll for responses with a body#5658edenbuilds wants to merge 1 commit into
edenbuilds wants to merge 1 commit into
Conversation
Pull-driven body streams were never consumed, so processResponseEndOfBody never ran and Cache.add hung forever. Clone, fully read (as Cache.put does), and store body.source. Fixes nodejs#5615. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache.add/Cache.addAllhung forever when the response had a body (204/no-body settled fine).fetchFinaleattachesstream.finished()for end-of-body, but undici body streams are pull-driven — with no consumer, the stream never finishes andprocessResponseEndOfBodynever resolves the waiters (issue Cache.add() and Cache.addAll() never settle for a response with a body #5615).Cache.put: clone the response, fully read the original stream (unlocks end-of-body), setbody.sourceon the clone for storage.Test plan
node --test test/web/cache-add-body.jscache.matchreturns body textMade with Cursor