perf(fhiaims): optimize regexes and switch imports to nomad_file_parser - #340
Merged
Merged
Conversation
blueraft
commented
Sep 2, 2026
blueraft
commented
Collaborator
- Switch import to nomad_file_parser
- Replace greedy regex in structure quantity with bounded non-greedy pattern
- Prioritize specific atom position regex over generic fallback
- Switch import to nomad_file_parser - Replace greedy regex in structure quantity with bounded non-greedy pattern - Prioritize specific atom position regex over generic fallback
Coverage Report for CI Build 33621803074Coverage decreased (-0.07%) to 92.767%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions28 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.