Skip to content

ci: skip govulncheck, docker build, and CodeQL (go) on docs-only changes - #4459

Open
reinkrul wants to merge 1 commit into
masterfrom
ci/skip-govulncheck-docker-codeql-docs-only
Open

ci: skip govulncheck, docker build, and CodeQL (go) on docs-only changes#4459
reinkrul wants to merge 1 commit into
masterfrom
ci/skip-govulncheck-docker-codeql-docs-only

Conversation

@reinkrul

Copy link
Copy Markdown
Member

Summary

Extends the docs-only CI skip pattern from #4455 (test, e2e-test) to the remaining workflows we control:

  • govulncheck.yamlgovulncheck_job
  • build-images.yamldocker
  • codeql-analysis.ymlanalyze (Analyze (go))

Same approach as #4455: a changes job using dorny/paths-filter detects whether anything outside docs/, *.md, *.rst changed, and the real job is gated with needs: changes + if: needs.changes.outputs.code == 'true'. A job skipped this way still reports as a passing check, so it's safe even if any of these were ever promoted to a required check later.

None of these three are currently required status checks, so this is purely a CI time/cost optimization, not a merge-blocking change.

Not touched

  • govulncheck-cron-schedule.yaml: schedule/workflow_dispatch only, doesn't run on PRs, so the skip doesn't apply.
  • GitHub's repo-level "default setup" code scanning for Actions and JavaScript/TypeScript (shows up as Analyze (actions) / Analyze (javascript-typescript) in checks): not backed by a workflow file in this repo, so it can't be gated this way — that's configured in repo Code Security settings.

Test plan

  • YAML syntax validated for all three edited files
  • This PR itself touches .github/**, so all jobs should run (not skip) — confirm on CI

Extends the docs-only skip pattern from #4455 (test, e2e-test) to the
remaining workflows we control: govulncheck, the docker image build,
and CodeQL's own Analyze (go) job. None of these are required status
checks, but they still burn CI time/minutes on changes that can't
affect Go code or the built image.

Not touched:
- govulncheck-cron-schedule.yaml: schedule/workflow_dispatch only,
  doesn't run on PRs, so the skip doesn't apply.
- GitHub's repo-level "default setup" code scanning for Actions and
  JavaScript/TypeScript (shows up as Analyze (actions) and
  Analyze (javascript-typescript) in checks): not backed by a workflow
  file in this repo, so it can't be gated this way.

Assisted by AI
Comment thread .github/workflows/govulncheck.yaml Outdated
Comment on lines 44 to 53
@reinkrul reinkrul added the Maintainer QoL Improves the life of Nuts maintainers label Aug 19, 2026
@qltysh

qltysh Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

❌ 11 blocking issues (11 total)

Tool Category Rule Count
zizmor Vulnerability overly broad permissions 8
zizmor Vulnerability credential persistence through GitHub Actions artifacts 3

@qltysh

qltysh Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer QoL Improves the life of Nuts maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants