NYL-22: Add Contact metadata and webhook parity - #759
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 43 43
Lines 1041 1041
Branches 90 90
=======================================
Hits 1028 1028
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AaronDDM
left a comment
There was a problem hiding this comment.
Good morning! Nice clean change — types, docs, changelog and tests are all here, and the contact.created guard test is a good touch.
Two notes below, neither blocking. Approving.
AaronDDM
left a comment
There was a problem hiding this comment.
Good morning! Re-reviewed after 881a3c4.
Both items from yesterday are addressed:
tests/apiClient.spec.tsnow asserts the real outgoing URL (metadata_pair=key1%3Async_eligible), which was the gap.- The multi-entry join in
apiClient.tsis pre-existing shared-serializer behavior and out of scope here — agreed on leaving it.
CHANGELOG has an Unreleased entry, doc comments cover the replace/preserve/clear semantics, and UpdateContactRequest picks up metadata via the alias to CreateContactRequest. No new concerns.
Approving.
Summary
Contact.metadatarequest/response typing andmetadataPaircontact filteringcontact.updatedandcontact.deletedwire values and guard against unsupportedcontact.createdTest plan
npm test -- --coverage=false(488 tests passed)npm run build