Skip to content

NYL-22: Add Contact metadata and webhook parity - #759

Merged
quzhi1 merged 2 commits into
mainfrom
codex/NYL-22-contacts-sdk-parity
Aug 28, 2026
Merged

NYL-22: Add Contact metadata and webhook parity#759
quzhi1 merged 2 commits into
mainfrom
codex/NYL-22-contacts-sdk-parity

Conversation

@quzhi1

@quzhi1 quzhi1 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Contact.metadata request/response typing and metadataPair contact filtering
  • document metadata replace, preserve, and clear behavior plus provider webhook support boundaries
  • verify contact.updated and contact.deleted wire values and guard against unsupported contact.created

Test plan

  • npm test -- --coverage=false (488 tests passed)
  • npm run build
  • Prettier on changed files

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (2bdf4ae) to head (881a3c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          43       43           
  Lines        1041     1041           
  Branches       90       90           
=======================================
  Hits         1028     1028           
  Misses         12       12           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AaronDDM AaronDDM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning! Nice clean change — types, docs, changelog and tests are all here, and the contact.created guard test is a good touch.

Two notes below, neither blocking. Approving.

Comment thread src/models/contacts.ts
Comment thread tests/resources/contacts.spec.ts

@AaronDDM AaronDDM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning! Re-reviewed after 881a3c4.

Both items from yesterday are addressed:

  • tests/apiClient.spec.ts now asserts the real outgoing URL (metadata_pair=key1%3Async_eligible), which was the gap.
  • The multi-entry join in apiClient.ts is pre-existing shared-serializer behavior and out of scope here — agreed on leaving it.

CHANGELOG has an Unreleased entry, doc comments cover the replace/preserve/clear semantics, and UpdateContactRequest picks up metadata via the alias to CreateContactRequest. No new concerns.

Approving.

@quzhi1
quzhi1 merged commit fabe2d6 into main Aug 28, 2026
11 checks passed
@quzhi1
quzhi1 deleted the codex/NYL-22-contacts-sdk-parity branch August 28, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants