Skip to content

fix: replace moonbitlang/core/strconv with core/string #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oboard merged 1 commit into from
Sep 6, 2026
Merged

fix: replace moonbitlang/core/strconv with core/string #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/mocket/main.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async fn main {
fn benchmark_port() -> Int {
match @env.get_env_var("PORT") {
Some(port_text) => {
let port : Int = @strconv.from_str(port_text) catch { _ => 3000 }
let port : Int = @string.from_str(port_text) catch { _ => 3000 }
port
}
None => 3000
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/mocket/moon.pkg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {
"moonbitlang/async",
"moonbitlang/core/env",
"moonbitlang/core/json",
"moonbitlang/core/strconv",
"moonbitlang/core/string",
"oboard/mocket" @mocket_lib,
}

Expand Down
2 changes: 1 addition & 1 deletion benchmarks/mocket_middleware/main.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ fn noop_middleware() -> @mocket_lib.Middleware {
fn benchmark_port() -> Int {
match @env.get_env_var("PORT") {
Some(port_text) => {
let port : Int = @strconv.from_str(port_text) catch { _ => 3000 }
let port : Int = @string.from_str(port_text) catch { _ => 3000 }
port
}
None => 3000
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/mocket_middleware/moon.pkg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {
"moonbitlang/async",
"moonbitlang/core/env",
"moonbitlang/core/json",
"moonbitlang/core/strconv",
"moonbitlang/core/string",
"oboard/mocket" @mocket_lib,
}

Expand Down
2 changes: 1 addition & 1 deletion examples/route/main.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ async fn main {
fn example_port() -> Int {
match @env.get_env_var("MOCKET_PORT") {
Some(port_text) => {
let port : Int = @strconv.from_str(port_text) catch { _ => 4000 }
let port : Int = @string.from_str(port_text) catch { _ => 4000 }
port
}
None => 4000
Expand Down
2 changes: 1 addition & 1 deletion examples/route/moon.pkg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
"moonbitlang/async",
"moonbitlang/core/env",
"moonbitlang/core/strconv",
"moonbitlang/core/string",
"oboard/mocket",
"oboard/mocket/cors",
}
Expand Down
1 change: 0 additions & 1 deletion moon.pkg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
"moonbitlang/async/websocket",
"moonbitlang/core/bench",
"moonbitlang/core/json",
"moonbitlang/core/strconv",
"moonbitlang/core/env",
"moonbitlang/core/string",
"moonbitlang/core/buffer",
Expand Down
Loading