Skip to content

cohttp_async_websocket need cohttp < 6 - #30754

Merged
mseri merged 1 commit into
ocaml:masterfrom
Kakadu:cohttp-async-websocket-bound
Sep 17, 2026
Merged

mseri merged 1 commit into
ocaml:masterfrom
Kakadu:cohttp-async-websocket-bound

Conversation

@Kakadu

@Kakadu Kakadu commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

check.ci.ocaml.org tries to install cohttp-async.6.0.0~beta2 and gets an error:

 Error: Modules do not match:
        sig
          module IO = Cohttp_async__Io.IO
          module Request = Cohttp_async.Io.Request
          module Response = Cohttp_async.Io.Response
        end
      is not included in Cohttp__.S.IO
      The type "t" is required but not provided
      File "cohttp/src/s.ml", line 23, characters 2-12: Expected declaration
      The value ">>=" is required but not provided

I beleive version constraints were setup incorreclty before:

➜  ~ dpkg --compare-versions 6.0.0~beta2  lt 6 && echo true || echo false
false
➜  ~ dpkg --compare-versions 6.0.0~beta2  lt 6.0.0 && echo true || echo false
true

check.ci.ocaml.org tries to install cohttp-async.6.0.0~beta2 and gets an
error:

````
 Error: Modules do not match:
        sig
          module IO = Cohttp_async__Io.IO
          module Request = Cohttp_async.Io.Request
          module Response = Cohttp_async.Io.Response
        end
      is not included in Cohttp__.S.IO
      The type "t" is required but not provided
      File "cohttp/src/s.ml", line 23, characters 2-12: Expected declaration
      The value ">>=" is required but not provided
````

I beleive version constraints were setup incorreclty before:

````
➜  ~ dpkg --compare-versions 6.0.0~beta2  lt 6 && echo true || echo false
false
➜  ~ dpkg --compare-versions 6.0.0~beta2  lt 6.0.0 && echo true || echo false
true
````

Signed-off-by: Kakadu <kakadu.hafanana@gmail.com>
@mseri

mseri commented Sep 17, 2026

Copy link
Copy Markdown
Member

Thanks

@mseri
mseri merged commit d730dc3 into ocaml:master Sep 17, 2026
4 of 5 checks passed
@Kakadu
Kakadu deleted the cohttp-async-websocket-bound branch September 18, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants