feat: include X-Protocol-Version header in PassportHttpClient requests - #1537
feat: include X-Protocol-Version header in PassportHttpClient requests#1537aanorbel wants to merge 4 commits into
X-Protocol-Version header in PassportHttpClient requests#1537Conversation
| passportAuthRegister = passportBridge::userAuthRegister, | ||
| passportAuthSubmit = passportBridge::userAuthSubmit, | ||
| getProxyOption = proxyManager::selected, | ||
| getProtocolVersion = { getManifest().map { it?.meta?.protocolVersion } }, |
There was a problem hiding this comment.
Is this getting the protocol version from the manifest? I think the one we want to deliver here is the protocol version currently running in the app, example of how this is done in the Python bindings: https://github.com/ooni/userauth/blob/cae34f0813f171fb941ac9514e088402d4cb276e/ooniauth-py/src/protocol.rs#L42-L47
It probably has to be exposed by the passport library but @mehul can confirm this. If not exposed we can assume "0.1.0" as that's the only version there is now
The idea is to get the protocol version running on the app to route them to different versions of the backend in case they are running a soon-to-deprecate version
The manifest is not a good proxy for this because the version there is what was reported by the backend and it can get updated
…nd not manifest protocol version
bd7440e to
5ba385e
Compare
3 participants
Related to OOPRIV-67