sync codex-universal - aug 2025 - #80
Conversation
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
|
@codex re review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| echo "- Node.js:" | ||
| for version in "18" "20" "22"; do | ||
| mise use --global "node@${version}" | ||
| node --version | ||
| npm --version | ||
| pnpm --version | ||
| yarn --version |
There was a problem hiding this comment.
[P1] Verifier switches Node toolchain away from nvm
The image installs Node 18/20/22 via nvm and pins specific npm/pnpm/yarn versions there, but the new verification script activates each Node version through mise use --global. mise installs its own Node builds and does not include the preinstalled pnpm/yarn binaries, so pnpm --version and yarn --version will either fail or report the wrong binaries when the script runs. It also overwrites the global ~/.tool-versions, leaving the final image defaulting to the mise-managed toolchain rather than the nvm setup that the runtime script (setup_universal.sh) expects. Consider using nvm use inside the verifier instead of mise so the check exercises the configured environment without replacing it.
Useful? React with 👍 / 👎.
2 participants
Uh oh!
There was an error while loading. Please reload this page.