Added UDP IPV4 Encapsulation Header as per requirement - #285
Open
keysightgems wants to merge 1 commit into
Open
Conversation
robshakir
requested changes
Aug 27, 2026
robshakir
left a comment
robshakir
left a comment
Member
There was a problem hiding this comment.
Thanks for the change.
Please can you also add a test into fluent_test.go's TestEntry table-driven test that validates that this functionality works as expected within an entry?
| } | ||
|
|
||
| // UDPV4EncapHeader returns a builder that can be used to build up a UDPv4 encapsulation header. | ||
| func UDPV4EncapHeader() *udpv4EncapHeader { |
Member
There was a problem hiding this comment.
Go style recommends that this should be UDPv4EncapHeader. Please can you update it here and throughout the change?
Suggested change
| func UDPV4EncapHeader() *udpv4EncapHeader { | |
| func UDPv4EncapHeader() *udpv4EncapHeader { |
| pb *aftpb.Afts_NextHop_EncapHeader | ||
| } | ||
|
|
||
| // UDPEncapHeader represents a UDP encapsulation header. |
Member
There was a problem hiding this comment.
Whilst you're changing this code, can you make this comment have the correct name please?
Suggested change
| // udpv6EncapHeader represents a UDP encapsulation header. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes were required based on the README/PR below, so I added the IPv4 UDP encapsulation header code accordingly. Please review and merge the changes.
Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/gribi/mpls_in_udp/otg_tests/mpls_in_udp_scale/README.md
Raised PR for the Readme: openconfig/featureprofiles#5714