feat(chart): add coresFromCgroup option for io-engine - #962
Open
TheRayquaza wants to merge 2 commits into
Open
Conversation
Wires up the io-engine --cores-from-cgroup flag behind an io_engine.coresFromCgroup values.yaml toggle, so the core list can be derived from the pod's kubelet-assigned cgroup cpuset instead of the static cpuCount/coreList. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Mateo Lelong <mateo.lelong@datadoghq.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Mateo Lelong <mateo.lelong@datadoghq.com>
TheRayquaza
force-pushed
the
feat/cores-from-cgroup
branch
from
August 4, 2026 09:30
d847180 to
575f7a8
Compare
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Abhinandan-Purkait
approved these changes
Aug 12, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
io_engine.coresFromCgroup(defaultfalse) tovalues.yaml.--cores-from-cgroupto the io-engine daemonset args, alongside the existing static-lcore list.--cores-from-cgroupflag to io-engine so it derives its reactor core list from the pod's kubelet-assigned cgroup cpuset (addresses IO Engine Cannot set affinity mayastor#1458).Test plan
helm linthelm templatewithcoresFromCgroup=trueand default (false) — flag present/absent as expected🤖 Generated with Claude Code