ASTIdentifierNode now inherits from ASTExpressionNode directly - #44
Open
nedyoNK wants to merge 1 commit into
Open
ASTIdentifierNode now inherits from ASTExpressionNode directly#44nedyoNK wants to merge 1 commit into
nedyoNK wants to merge 1 commit into
Conversation
|
Nedyo Kolibanekov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing this PR to resolve issue #6.
Changes made to simplify the code:
ASTExpressionNodeis moved fromASTTypes.hintoASTExpression.h. The constructors and methods ofASTExpressionNodethat require a completeASTIdentifierNodetype are placed inASTExpressionNodeImpl.h, which is included at the bottom ofASTExpression.hafterASTIdentifierNodeis fully defined.ASTQualifiers.hhad its circular includes removed; the three qualifier constructors takingconst ASTIdentifierNode&are moved toASTExpressionNodeImpl.h.ASTIdentifierNodenow inheritsASTExpressionNodeinstead ofASTExpression. TheEXPmember field and theSetExpression/GetExpression/HasExpressionmethods are removed fromASTIdentifierNodesince the relationship is now expressed via the inheritance hierarchy.GetIndexIdentifier()inASTIdentifierNodeis renamed toGetIndexIdentifierName()to avoid a return-type conflict withASTExpressionNode::GetIndexIdentifier(). Callers inASTBuilder.cppare updated correspondingly."If this solution is viable feel free to merge it. :)