Remove gitHubToken from deployment step - #2027
Merged
Merged
Conversation
Deploying opensafely-docs with
|
| Latest commit: |
c1b0553
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ee29dbd3.opensafely-docs.pages.dev |
| Branch Preview URL: | https://tomodwyer-remove-gh-deploy.opensafely-docs.pages.dev |
mikerkelly
approved these changes
Aug 4, 2026
mikerkelly
left a comment
mikerkelly
left a comment
Contributor
There was a problem hiding this comment.
Thanks, Thomas.
Tiny feedback: it could be useful to put a link to the documentation site in the git commit message for the benefit of the reader.
I assume that was https://github.com/marketplace/actions/deploy-cloudflare-pages-github-action or equivalent. Presumably there are many places with Cloudflare documentation.
As per the Cloudflare Docs[^1]: > Optional: Enable this if you want to have GitHub Deployments > triggered We do not use GitHub Deployments, so do not need this enabled [^1]: https://github.com/cloudflare/wrangler-action/blob/84c72882ef1dacec6f70cdca9666d4625494e009/README.md#deploy-your-pages-site-production--preview
tomodwyer
force-pushed
the
tomodwyer/remove-gh-deploy
branch
from
August 4, 2026 13:47
0482a09 to
c1b0553
Compare
Member
Author
|
@mikerkelly good point, I had the link in the issue, but it's better here. I've added that in and rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the Cloudflare Docs1:
We do not use GitHub Deployments, so do not need this enabled
Part of #2026
Footnotes
https://github.com/cloudflare/wrangler-action/blob/84c72882ef1dacec6f70cdca9666d4625494e009/README.md#deploy-your-pages-site-production--preview ↩