[#760] App Store 후보 빌드의 Firebase 연결 설정을 (default)와 공통 api로 전환한다#761
Merged
Conversation
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31686c44bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
(default)와 공통api로 전환한다 #760🎯 의도
(default)데이터베이스와 공통 Functions API 경로를 사용하도록 Release 설정과 Fastlane 검증 기준 정렬Fastfile에서 제거하고 비공개 설정으로 소유권 이동📝 작업 내용
📌 요약
Application/App/Project.swift의 ReleaseFIRESTORE_DATABASE_ID를prod에서(default)로 변경fastlane/Fastfile의 Store별FUNCTION_API_BASE_URL과 Firebase 기대 식별자를Config.xcconfig에서 조회하도록 변경/api/api, 쿼리·프래그먼트 미포함 정책 검증 추가FUNCTION_API_BASE_URL,PROJECT_ID,GOOGLE_APP_ID원문 제거🔍 상세
Staging과Release구성별 비공개 기대값을 빌드 전 검증과 IPA 내부Info.plist,GoogleService-Info.plist검증에 재사용APP_ENVIRONMENT, bundle ID, Firestore ID, Functions URL, Crashlytics 설정, Firebase 식별자 일치 여부 검증 유지·강화54b08a4연동📸 영상 / 이미지 (Optional)