Add osac-ci-bot to fulfillment-wg - #199
Merged
eliorerz merged 1 commit intoAug 25, 2026
Merged
Conversation
osac-ci-bot runs the merge-queue automation in osac-project/osac (auto-queue.yml: label removal, review dismissal, collaborator checks, auto-merge enable/disable; konflux-auto-label.yml: labeling Konflux dependency-bump PRs), but wasn't a member of any team, so it had no path to elevated repo access and fell back to the org default (read). A fine-grained PAT owned by this account can never exceed its actual collaborator role, regardless of what permissions the token itself requests -- confirmed live: every mutating call (label add, review dismiss, collaborator check, auto-merge enable/disable) 403'd until this grant exists, even with the token's own permissions correctly configured. fulfillment-wg already grants push on osac, osac-test-infra, and github-config (among others), matching what MERGE_QUEUE_TOKEN effectively has today -- same team osac-dev-bot (another bot account) is already a plain member of. Signed-off-by: Elior Erez <eerez@redhat.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
osac-ci-botruns the merge-queue automation inosac-project/osac:auto-queue.yml: removeslgtmon push, dismisses changes-requested reviews, checks collaborator status, enables/disables auto-mergekonflux-auto-label.yml: labels Konflux dependency-bump PRsIt wasn't a member of any team here, so it had no path to elevated repo access and fell back to the org default (
read). A fine-grained PAT owned by this account can never exceed its actual collaborator role, regardless of what permissions the token itself requests — confirmed live against the real API: every mutating call (label add, review dismiss, collaborator check, auto-merge enable/disable) returned 403, even after configuring the token's own fine-grained permissions correctly (Contents: write,Pull requests: write,Administration: read) and getting it approved by an org owner.Fix
One line: add
osac-ci-bottofulfillment-wginteam-members/fulfillment-wg.csv. That team already grantspushonosac,osac-test-infra, andgithub-config(among others) — matching what the existingMERGE_QUEUE_TOKEN(a personal token) effectively has today.osac-dev-bot, another bot account, is already a plain member of this same team, so this isn't a new pattern.Verification
tofu fmt -check— clean (no formatting changes needed, plain CSV edit)tofu validate— succeeds (only pre-existing, unrelated deprecation warnings)osac-ci-botis already an org member (members.csv) and not currently in any team (team-members/*.csv) before this changeGET /repos/osac-project/osac/collaborators/osac-ci-bot/permission) that its current effective permission isread, consistent with having no team-based grant anywhere