fix: make the native libpostal backend opt-in - #1129
Open
immanuwell wants to merge 1 commit into
Open
immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native libpostal was getting picked whenever cgo was on. On a pretty normal Linux box, that makes
go test ./...blow up ifpkg-configcant find libpostal, even though the HTTP fallback is already there.This makes the native path opt-in via
-tags libpostal. Default builds use the fallback now, tagged builds still use the cgo backend. Small fix, but it saves a dumb install footgun.Repro
go env CGO_ENABLED go test ./...Before
Checks
On this machine the default path now picks
pure_go.go, and the tagged path still pickscgo_specific.go.