Skip to content

fix: guard startSyncFolderOperation against a null folder (#4738) #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joragua merged 2 commits into from
Sep 29, 2026
Merged

fix: guard startSyncFolderOperation against a null folder (#4738) #4986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caff30d
chore: add calens file
ibrahim-iqbal Sep 26, 2026
2698bec
fix: guard startSyncFolderOperation against a null folder (#4738)
ibrahim-iqbal Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/4986
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Crash when returning from external-file receive screen

A null guard has been added to `startSyncFolderOperation` in `ReceiveExternalFilesActivity` to prevent a NullPointerException when `getCurrentDir()` cannot resolve the current folder.

https://github.com/owncloud/android/issues/4738
https://github.com/owncloud/android/pull/4986
4 changes: 4 additions & 0 deletions owncloudApp/src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,10 @@ public void onSavedCertificate() {
}

private void startSyncFolderOperation(OCFile folder) {
if (folder == null) {
Timber.w("startSyncFolderOperation called with a null folder; skipping sync");
return;
}

mSyncInProgress = true;

Expand Down
Loading