wip tagged nat_apply - #333
Draft
nicolaskagami wants to merge 8 commits into
Draft
Conversation
nicolaskagami
force-pushed
the
nsk/service-nat-entries
branch
from
August 6, 2026 14:50
7fa4258 to
267c875
Compare
nicolaskagami
force-pushed
the
nsk/service-nat-entries
branch
2 times, most recently
from
August 7, 2026 12:48
ce210d2 to
b19eeae
Compare
nicolaskagami
force-pushed
the
nsk/nat-3-natmap
branch
from
August 7, 2026 12:48
529d8bc to
789c30c
Compare
PUT /nat/tagged/{tag}/ipv4 and /ipv6 take the complete desired set of
NAT entries for a tag, diff it against current state under a single
acquisition of the NAT lock, and converge. Entries created this way
carry the tag; entries absent from a later apply are removed, and an
empty apply removes them all. Conflicts with entries not carrying the
tag and dataplane failures are reported per entry rather than failing
the request. GET on the same paths lists the entries carrying a tag.
Cover convergence (add/remove/retarget/idempotent re-apply), isolation between tags and from untagged entries, per-entry conflict reporting, wholesale rejection of invalid requests, empty-apply removal, and tagged list pagination.
Adds nat apply-ipv4/apply-ipv6, which read a JSON array of NAT entries and PUT it as the complete set for a tag, and a -t/--tag filter on nat list.
nicolaskagami
force-pushed
the
nsk/nat-3-natmap
branch
from
August 7, 2026 13:47
789c30c to
61774ca
Compare
nicolaskagami
force-pushed
the
nsk/service-nat-entries
branch
from
August 7, 2026 13:47
b19eeae to
211e43e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.