You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2639 made the e2e deploy and restore leave monerod and tari running when the branch leaves them unchanged. Both deploying e2e modes, targeted and matrix, also run --lifecycle (tests/integration/lib/run-lifecycle.sh). That phase drives pithead from the e2e checkout:
a whole-stack restart
a pool-flip pithead apply -y
a down → restore → up backup round trip
Both chain services bind-mount paths inside the checkout, which Compose hashes into their config (#2650). So the apply and the round trip recreate both nodes from the e2e checkout on every deploying run, and the restore then recreates them again from the baseline. The restore proof records this as "recreated", which is correct, but bench-ci can never skip its node-guard write for a deploying e2e job. That skip is the goal #2639 was filed for (bench-ci#599).
Options
Run lifecycle's apply and up with PITHEAD_KEEP_RUNNING over the nodes the deploy kept (CHAIN_KEPT). The restart and the backup round trip stop the nodes by design, so they would still need the guard.
Split --lifecycle into a node-touching part and a part that is not, and run only the second in targeted.
A deploying e2e mode exists whose run leaves unchanged chain nodes with the same container ID and start time from deploy to restore, and bench-ci can key its node guard off it.
Problem
#2639 made the e2e deploy and restore leave
monerodandtarirunning when the branch leaves them unchanged. Both deploying e2e modes,targetedandmatrix, also run--lifecycle(tests/integration/lib/run-lifecycle.sh). That phase drivespitheadfrom the e2e checkout:restartpithead apply -ydown→restore→upbackup round tripBoth chain services bind-mount paths inside the checkout, which Compose hashes into their config (#2650). So the apply and the round trip recreate both nodes from the e2e checkout on every deploying run, and the restore then recreates them again from the baseline. The restore proof records this as "recreated", which is correct, but bench-ci can never skip its node-guard write for a deploying e2e job. That skip is the goal #2639 was filed for (bench-ci#599).
Options
upwithPITHEAD_KEEP_RUNNINGover the nodes the deploy kept (CHAIN_KEPT). Therestartand the backup round trip stop the nodes by design, so they would still need the guard.--lifecycleinto a node-touching part and a part that is not, and run only the second intargeted.downremains.Acceptance
A deploying e2e mode exists whose run leaves unchanged chain nodes with the same container ID and start time from deploy to restore, and bench-ci can key its node guard off it.