Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator always permits TCP/443 to every destination, including private addresses, so custom egress rules cannot restrict HTTPS access. Add
spec.security.networkPolicy.allowHTTPS, an optional boolean defaulting totrue. Setting it tofalseremoves the unrestricted HTTPS rule so users can allow specific destinations throughadditionalEgresswhile retaining operator-managed networking.Omitted and explicit
truevalues preserve existing behavior. DNS, custom rules, allowed CIDRs, and feature-specific egress remain unchanged. Includes regenerated CRDs for all installation paths, DeepCopy code, API reference, and a restrictive policy example.Validation:
make testpassed, including controller envtest andgo vet.GOTOOLCHAIN=go1.25.0 make lintpassed using the CI toolchain.de702a9and the local Helm chart/CRDs. Omitting the field storedtrue; patching tofalseremoved only unrestricted TCP/443; patching back totruerestored the original policy without recreating it. Explicitfalsealso survived initial creation. DNS, custom egress, ingress, and policy types were preserved.The kind test used suspended instances to validate installation, API defaulting/storage, and reconciliation without starting the OpenClaw workload. Network traffic enforcement was not tested.