chore(docs): Replace ActionGroup with ActionList#12589
Conversation
WalkthroughActionGroup is marked deprecated. FormGroup gains an action modifier, while Form examples, login, search, and demo components replace ActionGroup layouts with ActionList structures and preserve existing button behavior. ChangesActionList migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes patternfly/patternfly#8486 Co-authored-by: Cursor <cursoragent@cursor.com>
42534ef to
3b03b28
Compare
|
Ah, looking at Core, it looks like the action groups would still be in form groups - we lost that with the switch. That should restore the spacing differences. I can add that here, assuming Core is the example to follow. Going to move this back to Draft. |
c507295 to
b82d4cd
Compare
|
Should now match structure in Core. |
What: Part of patternfly/patternfly#8486
This button went from full-width to not (I didn't see a prop for this):
http://localhost:8002/components/login-page/react/basic
Others have slight spacing changes above or horizontally, but tabbing looks better.
I didn't see any internal usage in form, but we use the action group naming convention in certain styles, etc.
Additional issues:
patternfly/patternfly#8527
Summary by CodeRabbit
Summary by CodeRabbit
Documentation
New Features
isActionprop toFormGroupto enable the “action” styling variant.Refactor
ActionListlayout, preserving existing labels, behaviors, validation, loading, and conditional rendering.Deprecation
ActionGroupPropsas deprecated.Tests
FormGroupaction variant styling.