Skip to content

chore(docs): Replace ActionGroup with ActionList#12589

Open
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:action-group
Open

chore(docs): Replace ActionGroup with ActionList#12589
rebeccaalpert wants to merge 2 commits into
patternfly:mainfrom
rebeccaalpert:action-group

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jul 23, 2026

Copy link
Copy Markdown
Member

What: Part of patternfly/patternfly#8486

This button went from full-width to not (I didn't see a prop for this):
http://localhost:8002/components/login-page/react/basic

Others have slight spacing changes above or horizontally, but tabbing looks better.

I didn't see any internal usage in form, but we use the action group naming convention in certain styles, etc.

Additional issues:
patternfly/patternfly#8527

Summary by CodeRabbit

Summary by CodeRabbit

  • Documentation

    • Updated Form documentation to include additional related action list components.
  • New Features

    • Added an isAction prop to FormGroup to enable the “action” styling variant.
  • Refactor

    • Updated Form, login, search, and button examples to render action buttons using the ActionList layout, preserving existing labels, behaviors, validation, loading, and conditional rendering.
  • Deprecation

    • Marked ActionGroupProps as deprecated.
  • Tests

    • Updated Cypress selectors for advanced search action buttons to match the new action list structure.
    • Added a unit test to verify FormGroup action variant styling.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

ActionGroup is marked deprecated. FormGroup gains an action modifier, while Form examples, login, search, and demo components replace ActionGroup layouts with ActionList structures and preserve existing button behavior.

Changes

ActionList migration

Layer / File(s) Summary
Form action migration
packages/react-core/src/components/Form/ActionGroup.tsx, packages/react-core/src/components/Form/FormGroup.tsx, packages/react-core/src/components/Form/examples/*, packages/react-core/src/components/Form/__tests__/FormGroup.test.tsx
Deprecates ActionGroupProps, adds and tests FormGroup isAction, updates Form documentation metadata, and migrates Form example action controls to ActionList structures.
Component action migration
packages/react-core/src/components/LoginPage/LoginForm.tsx, packages/react-core/src/components/SearchInput/AdvancedSearchMenu.tsx, packages/react-integration/cypress/integration/searchinput.spec.ts
Replaces action containers with ActionList components while preserving button properties and callbacks, and updates the integration-test selector.
Demo action migration
packages/react-core/src/demos/Button/examples/ButtonProgress.tsx, packages/react-core/src/demos/SearchInput/examples/SearchInputAdvancedComposable.tsx
Migrates demo action layouts without changing existing interaction logic.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • patternfly/patternfly#8486 — Directly addresses deprecating ActionGroup and replacing it with ActionList in Form examples.

Suggested reviewers: kmcfaul, thatblindgeye

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: replacing ActionGroup with ActionList across the PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rebeccaalpert
rebeccaalpert marked this pull request as draft July 23, 2026 19:31
Fixes patternfly/patternfly#8486

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert
rebeccaalpert marked this pull request as ready for review July 24, 2026 13:57
@rebeccaalpert

Copy link
Copy Markdown
Member Author

Ah, looking at Core, it looks like the action groups would still be in form groups - we lost that with the switch. That should restore the spacing differences. I can add that here, assuming Core is the example to follow. Going to move this back to Draft.

@rebeccaalpert
rebeccaalpert marked this pull request as draft July 24, 2026 14:53
@rebeccaalpert
rebeccaalpert marked this pull request as ready for review July 24, 2026 15:51
@rebeccaalpert

Copy link
Copy Markdown
Member Author

Should now match structure in Core.

@rebeccaalpert
rebeccaalpert requested a review from mcoker July 24, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant