Remove flakehub api call in nix cache action in CI - #1798
Merged
Conversation
Collaborator
Coverage Report for CI Build 31516697017Coverage remained the same at 86.718%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
force-pushed
the
nix-no-cache-test
branch
from
August 5, 2026 19:30
2880297 to
514e08e
Compare
benalleng
force-pushed
the
nix-no-cache-test
branch
from
August 11, 2026 17:16
2550db2 to
49876cd
Compare
benalleng
changed the title
benalleng
marked this pull request as ready for review
August 11, 2026 20:57
spacebear21
approved these changes
Aug 11, 2026
spacebear21
left a comment
spacebear21
left a comment
Collaborator
There was a problem hiding this comment.
cACK/utACK, we should really investigate whether we are making effective use of github cache as it stands currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The magic-nix-cache-action was calling the flakehub api when we do not have an account for it. This keeps the action and just uses the standard github cache storage space.
As a note the github cache space is limited at our current tier. Perhaps it is worth exploring whether or not this job is totally worth it if our repo immediately fills the cache space.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.