Skip to content

Issue 8.6.0beta1 - #233

Open
remicollet wants to merge 2 commits into
php-ds:masterfrom
remicollet:issue-8.6.0beta1
Open

Issue 8.6.0beta1#233
remicollet wants to merge 2 commits into
php-ds:masterfrom
remicollet:issue-8.6.0beta1

Conversation

@remicollet

Copy link
Copy Markdown
Contributor

This PR also includes the commit from #230

return;
}
}
index = zval_get_long_ex(offset, true);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have the same semantics as ZPP as it won't emit a deprecation on NULL nor reject arrays

@Jan-E

Jan-E commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Oops. As simple as
index = zval_get_long_ex(offset, true);
for all those lines in #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants