Skip to content

Select 1.3 server resumption tickets - #1180

Merged
JoTurk merged 1 commit into
mainfrom
jo/select-resumption-tickets
Oct 3, 2026
Merged

JoTurk merged 1 commit into
mainfrom
jo/select-resumption-tickets

Conversation

@JoTurk

@JoTurk JoTurk commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Description

This is the last PR for resumption (which was pretty short <200 loc in total) before wiring everything and adding interop and 0 RTT.
Select compatible cached tickets and verify PSK binders. This fallbacks to external PSKs or a full handshake when no ticket matches.

Respects the limit added in: #1165

As discussed resmption is only allowed for DHE because KE lacks forward secrecy.
KE is still allowed for the fallback handshake.

Reference issue

part of: #981

@JoTurk
JoTurk force-pushed the jo/select-resumption-tickets branch from c8a18fc to 0e1eb1b Compare October 3, 2026 19:24
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.62%. Comparing base (d20a76a) to head (b8ce6f7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/handshake/psk_handshake.go 53.84% 12 Missing ⚠️

❌ Your patch status has failed because the patch coverage (61.29%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
- Coverage   77.68%   77.62%   -0.07%     
==========================================
  Files         140      140              
  Lines       11676    11698      +22     
==========================================
+ Hits         9071     9080       +9     
- Misses       2601     2614      +13     
  Partials        4        4              
Flag Coverage Δ
go 77.62% <61.29%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk

JoTurk commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

thank you so much @Julia-Roman

Select compatible cached tickets and verify PSK
binders. This fallbacks to external PSKs
or a full handshake when no ticket matches.

Respects the limit added in:
#1165

As discussed resmption is only allowed for DHE
because KE lacks forward secrecy.
KE is still allowed for the fallback handshake.

part of:
#981
@JoTurk
JoTurk force-pushed the jo/select-resumption-tickets branch from 0e1eb1b to b8ce6f7 Compare October 3, 2026 19:30
@JoTurk
JoTurk merged commit b8ce6f7 into main Oct 3, 2026
22 of 23 checks passed
@JoTurk
JoTurk deleted the jo/select-resumption-tickets branch October 3, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants