Select 1.3 server resumption tickets - #1180
Merged
Merged
Conversation
JoTurk
force-pushed
the
jo/select-resumption-tickets
branch
from
October 3, 2026 19:24
c8a18fc to
0e1eb1b
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (61.29%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
- Coverage 77.68% 77.62% -0.07%
==========================================
Files 140 140
Lines 11676 11698 +22
==========================================
+ Hits 9071 9080 +9
- Misses 2601 2614 +13
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Julia-Roman
approved these changes
Oct 3, 2026
Member
Author
|
thank you so much @Julia-Roman |
Select compatible cached tickets and verify PSK binders. This fallbacks to external PSKs or a full handshake when no ticket matches. Respects the limit added in: #1165 As discussed resmption is only allowed for DHE because KE lacks forward secrecy. KE is still allowed for the fallback handshake. part of: #981
JoTurk
force-pushed
the
jo/select-resumption-tickets
branch
from
October 3, 2026 19:30
0e1eb1b to
b8ce6f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the last PR for resumption (which was pretty short <200 loc in total) before wiring everything and adding interop and 0 RTT.
Select compatible cached tickets and verify PSK binders. This fallbacks to external PSKs or a full handshake when no ticket matches.
Respects the limit added in: #1165
As discussed resmption is only allowed for DHE because KE lacks forward secrecy.
KE is still allowed for the fallback handshake.
Reference issue
part of: #981