Chore(deps-dev): Bump eslint-plugin-unicorn from 71.1.0 to 72.0.0 in /extension - #365
Merged
twschiller merged 2 commits intoJul 28, 2026
Merged
Conversation
dependabot
Bot
added
dependencies
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dependabot
Bot
added
dependencies
dependabot
Bot
force-pushed
the
dependabot/bun/extension/eslint-plugin-unicorn-72.0.0
branch
from
July 28, 2026 18:14
1fedf02 to
dbbaf46
Compare
Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 71.1.0 to 72.0.0. - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v71.1.0...v72.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-unicorn dependency-version: 72.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
eslint-plugin-unicorn 72 promotes prefer-dom-node-html-methods and prefer-simple-condition-first to recommended; they flag 19 existing sites (13 + 6). Keep both rules enforced as errors so new code can't add violations, and record the current sites in an ESLint bulk-suppressions file to burn down over time. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
twschiller
force-pushed
the
dependabot/bun/extension/eslint-plugin-unicorn-72.0.0
branch
from
July 28, 2026 18:48
dbbaf46 to
605ddea
Compare
twschiller
deleted the
dependabot/bun/extension/eslint-plugin-unicorn-72.0.0
branch
July 28, 2026 18:50
twschiller
added a commit
that referenced
this pull request
Jul 29, 2026
The unicorn 71→72 bump (#365) recorded 19 existing violations of two newly-recommended rules in extension/eslint-suppressions.json instead of addressing them. Burn the file down to empty. prefer-simple-condition-first (6 sites): reorder each `&&`/`||` so the cheap operand short-circuits first. Every site's operands are pure and independent, so the reordering is behavior-preserving (the rule's own message defers this check to a human, which is why its autofix stays its hand). Stays at recommended `error`. prefer-dom-node-html-methods (13 sites): turned off. The rule rewrites `.innerHTML` reads to `element.getHTML()`, but for a read the two are equivalent — getHTML()'s only added value is its shadow-root serialization options, which the fix doesn't pass. getHTML() is also a recent DOM API absent from jsdom, and 12 of the 13 hits are jsdom tests asserting on serialized output, so the rewrite would throw at runtime (same test-runtime block as prefer-uint8array-base64). No upside. check + typecheck + affected tests (338) green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps eslint-plugin-unicorn from 71.1.0 to 72.0.0.
Release notes
Sourced from eslint-plugin-unicorn's releases.
Commits
0b9a9af72.0.079e79d5consistent-boolean-name: Support Vue refs (#3555)b23f959prefer-split-limit: Support array destructuring (#3554)110cc58no-unused-array-method-return: Ignore expect assertions (#3552)305fb4bprefer-await: Add async IIFE suggestion (#3550)a1615b6UpdatedefineConfigconfig docs (#3524)6ae0e95prefer-await: Show exact solutions to incorrect code in docs (#3546)4367228no-useless-template-literals: Ignore const assertions (#3543)b6d01a0no-unnecessary-array-flat-map: Handle TypeScript Vue files (#3545)e273ab6prefer-export-from: Preserve JSDoc comments on single-const re-exports (#3544)