chore: hold ESLint at v9 in Renovate - #354
Merged
Merged
Conversation
ESLint 10 fails #348's lint job before linting anything: eslint-plugin-react 7.37.5 calls context.getFilename(), which ESLint 10 removed. It has no release that supports ESLint 10, and neither does eslint-plugin-jsx-a11y; both come from @playcanvas/eslint-config. This repo's own lib and blocks configs also use eslint-plugin-import, which has no ESLint 10 release either. Hold eslint below 10 until those plugins are updated or replaced, like the existing typescript and changesets/action holds. With eslint back on 9.39.5 and the rest of #348 unchanged (including globals 17), lint passes locally with the same warnings as main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #351, the only check failing on Renovate's grouped major PR #348 is lint, and the cause is ESLint 10. It crashes before linting anything:
ESLint 10 removed
context.getFilename(), andeslint-plugin-react7.37.5 still calls it. That can't be fixed in this repo yet:eslint-plugin-react(latest 7.37.5) andeslint-plugin-jsx-a11y(latest 6.10.2) have no release that supports ESLint 10. Both come from@playcanvas/eslint-config, whose newest release is 3.0.0-beta.8.eslint-plugin-jsdocsupports ESLint 10 from 64.x, but the shared config pins^61.packages/{lib,blocks}/eslint.config.mjsuseeslint-plugin-import(latest 2.32.0) forimport/extensions, which has no ESLint 10 release either.eslint-plugin-import-x, which the shared config already uses, does support it.Change
Hold
eslintbelow 10 inrenovate.jsonuntil those plugins are updated or replaced, in the same form as the existingtypescriptandchangesets/actionholds.Verification
I simulated #348 with
eslintback on 9.39.5 and everything else from Renovate's branch unchanged, includingglobals17.12.0. Lint passes with 0 errors and the same warnings as main. Build, test and publish already pass on #348, so it should go green once Renovate dropseslint.#348 still shouldn't be merged while it moves
@changesets/clito v3 withoutchangesets/actionv2. That combination would silently skip pushing git tags and creating GitHub releases.🤖 Generated with Claude Code