Changes to improve build and test and removed need for nuspec (which incorrectly references Newtonsoft now) - #58
Open
Colin Dekker (colindekker) wants to merge 3 commits into
Open
Colin Dekker (colindekker) wants to merge 3 commits into
Colin Dekker (colindekker) wants to merge 3 commits into
Conversation
…Core XUnit Test project. Tests pass for both frameworks using dotnet test Pliivo.Test.csproj
…notes to Plivo project and setting create package on build to true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the current Plivo NuGet package, the consuming projects get a build warning due to the way the dependency in the nuspec was annotated.
To circumvent this it's possible to have the csproj be the nuspec as csproj files are now fully part of the build and development process (either set manually or using the project proeprties in Visual Studio).
Then I looked at the two test projects and removed the old, NUnit one because it's not needed. I multi-targetted the .NET Core test project to netcoreapp1.1 and net461 then ran the command line dotnet test which will run every available framework.
Cleaned up some files, moved and renamed the .NET Core Test projet to be just Plivo.Test as it replaces the old NUnit project