Skip to content

Fix: correct entity and ticket validation in credit forms - #242

Merged
Rom1-B merged 1 commit into
mainfrom
fix_entity
Jul 27, 2026
Merged

Rom1-B merged 1 commit into
mainfrom
fix_entity

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes #N/A
  • This fixes several forms and endpoints of the Credit plugin so that voucher creation, voucher configuration and ticket consumption records are always validated against the correct entity and the correct ticket.
  • Previously some of these checks were missing, inverted, or applied to the wrong record, which could let a request affect a voucher or a ticket outside the caller's expected scope.
  • The consumption history view and the quantity preview endpoint now also verify entity access before returning data.

Screenshots (if appropriate):

@Rom1-B
Rom1-B requested a review from Lainow July 24, 2026 07:51
@Rom1-B
Rom1-B merged commit b2cab2c into main Jul 27, 2026
3 checks passed
@Rom1-B
Rom1-B deleted the fix_entity branch July 27, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants