Fix negative default value on models entities_id column - #645
Open
Herafia wants to merge 3 commits into
Open
Conversation
Rom1-B
requested changes
Jul 27, 2026
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Rom1-B
requested changes
Jul 28, 2026
| $migration->executeMigration(); | ||
| } | ||
|
|
||
| function plugin_datainjection_migration_2158_2159(Migration $migration) |
Contributor
There was a problem hiding this comment.
The redundant migrationOneTable() call was removed (per the requested suggestion), but the core fix was not applied: the legacy-data cleanup is still queued with addPostQuery() instead of addPreQuery(). Migration::executeMigration() still processes the changeField()-registered ALTER TABLE before running POST_QUERY entries, so the UPDATE clearing -1 rows still runs after the column is converted to unsigned, and the ordering bug the finding described remains unresolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
-1default onglpi_plugin_datainjection_models.entities_id, which blocked GLPI 11'smigration:unsigned_keys. Adds a migration resetting the column default to 0(and fixing any remaining
-1rows).