Widen scikit-learn constraint to <2 - #8
Merged
Conversation
The <=1.4.2 pin came from a blanket version-pinning commit; the only sklearn usage is Ridge from sklearn.linear_model, which is stable across 1.x releases. Match the style of the numpy/pandas constraints. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FT7d8d2E3FansicmSzJ1SW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description of Changes
Widens the scikit-learn version constraint in
setup.pyfromscikit-learn<=1.4.2toscikit-learn<2, allowing installation alongside current scikit-learn 1.x releases.The
<=1.4.2pin dates back to a blanket version-pinning commit (0ad96ce) that also pinned numpy and pandas; those two constraints have since been widened (numpy<3,pandas>=2,<4) while scikit-learn was left behind. The only scikit-learn usage in the codebase isRidgefromsklearn.linear_model(src/pyace/linearacefit.py), a stable API across 1.x releases, so an upper bound at the next major version matches the style used for the other dependencies.Checklist
License Agreement
By submitting this pull request, I agree that:
🤖 Generated with Claude Code
https://claude.ai/code/session_01FT7d8d2E3FansicmSzJ1SW
Generated by Claude Code