Skip to content

Regenerate protobuf files from buf - #71

Merged
lennysgarage merged 2 commits into
mainfrom
buf-generate-update
Oct 19, 2026
Merged

lennysgarage merged 2 commits into
mainfrom
buf-generate-update

Conversation

@lennysgarage

@lennysgarage lennysgarage commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added operations to add or remove specified relationships for a resource.
    • Adding relationships creates the reporter’s resource representation if it does not exist; removing relationships returns NOT_FOUND when the resource is missing.
    • Both operations accept relationship fields only and affect relationship-check results. Immediate read-after-write visibility can be requested.

@lennysgarage
lennysgarage requested a review from a team as a code owner October 19, 2026 16:28
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: project-kessel/kessel-sdk-node/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 392f0c74-6556-4404-9c3c-10d8f333412f
📥 Commits

Reviewing files that changed from the base of the PR and between 6ad31dd and 3ba6002.

📒 Files selected for processing: 5
  • src/kessel/inventory/v1beta2/add_resource_relationships_request.ts
  • src/kessel/inventory/v1beta2/add_resource_relationships_response.ts
  • src/kessel/inventory/v1beta2/inventory_service.ts
  • src/kessel/inventory/v1beta2/remove_resource_relationships_request.ts
  • src/kessel/inventory/v1beta2/remove_resource_relationships_response.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

Adds generated protobuf TypeScript messages for adding and removing resource relationships. Extends KesselInventoryService with unary RPC definitions, serializers, server handlers, and client overloads for both operations.

Changes: Resource relationship mutations

Layer / File(s) Summary
Request and response message codecs
src/kessel/inventory/v1beta2/add_resource_relationships_request.ts, src/kessel/inventory/v1beta2/remove_resource_relationships_request.ts, src/kessel/inventory/v1beta2/add_resource_relationships_response.ts, src/kessel/inventory/v1beta2/remove_resource_relationships_response.ts
Adds protobuf and JSON conversion, default initialization, and partial construction for the relationship requests and empty responses.
Unary service definitions
src/kessel/inventory/v1beta2/inventory_service.ts
Adds service definitions, serializers and deserializers, server handlers, and client overloads for both RPCs.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Suggested reviewers: josejulio

Merge Risk: ⚪ Minimal · up to 3ba60

The new relationship mutation messages follow the package’s existing import pattern. No merge-blocking risk is established beyond normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: regenerating protobuf TypeScript files from buf.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 2
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@tonytheleg tonytheleg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lennysgarage
lennysgarage merged commit 8b8b44d into main Oct 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants