Refactor mysqld_exporter to make it re-usable as a Go library - #1043
Open
ArthurSens wants to merge 9 commits into
Open
Refactor mysqld_exporter to make it re-usable as a Go library#1043ArthurSens wants to merge 9 commits into
ArthurSens wants to merge 9 commits into
Conversation
macabu
reviewed
Sep 11, 2026
macabu
left a comment
macabu
left a comment
There was a problem hiding this comment.
Obviously not familiar with the codebase so take everything with a big grain of salt 😃
ArthurSens
force-pushed
the
refactor
branch
from
September 11, 2026 11:34
def89f0 to
c9e04de
Compare
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
ArthurSens
force-pushed
the
refactor
branch
from
September 11, 2026 11:39
c9e04de to
f336dec
Compare
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Member
Author
|
Thanks for the review @macabu , I believe I've addressed most of the comments! |
Member
Author
|
@SuperQ, wanna take a look? Things looks mostly ready to be merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the mysqld_exporter, following the guidelines documented here.
The goal is to facilitate the use case where mysql_exporter runs as part of other applications, using mysqld_exporter as a Go library.