Creating DSN using database name. - #909
Open
BeniaminK wants to merge 1 commit into
Open
Conversation
Signed-off-by: Beniamin Kalinowski <beniamin.kalinowski@gmail.com>
ArthurSens
requested changes
Sep 6, 2026
ArthurSens
left a comment
ArthurSens
left a comment
Member
There was a problem hiding this comment.
Hey, sorry for the super delayed review. It's a good change to enable configuring a default database, but as it is the chosen database won't filter all metric collectors to chose the configured database.
This information needs to be passed down to metric collectors so the filter applies everywhere.
It would also be awsome to have tests around the behavior we want to introduce here :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the ability to specify a database name in the Data Source Name (DSN) configuration for the MySQL exporter.
Previously, the exporter would connect to the default database if no database name was provided.
With this change, users can define a specific database name in the configuration.