Repository navigation
Add PR triage skills: status labeller + Mon/Wed/Fri digest #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
28021f0
Add PR triage skills: status labeller + Mon/Wed/Fri digest
1058868
Fix ruff lint + BugBot findings in PR triage skills
daimon-pymclabs e26d69f
Make NEXT_ACTION_ORDER drive _next_action precedence (BugBot finding 2)
claude c62eb0d
Fix idle-timer reset by label writes; ruff-format the triage core
daimon-pymclabs 157e87a
Fix remaining BugBot findings in PR triage core
e676d44
Fail loudly on per-PR detail fetch failure (BugBot)
daimon-pymclabs 04834ea
Make an incomplete fetch neutral, not destructive (BugBot)
daimon-pymclabs b3645e9
Treat STALE checks as red; stop trusting/printing raw data (BugBot)
daimon-pymclabs 4d6dbd5
Sort queued hard items by age, oldest first (review)
daimon-pymclabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Shared PR triage core | ||
|
|
||
| `labels.py` is the single deterministic source of truth for CausalPy PR triage. | ||
| It fetches open PRs via `gh`, computes a set of orthogonal facts per PR | ||
| (lifecycle, conflict, CI, review, decision-needed, risk, idle-band, | ||
| author-class), and derives one `next_action` per PR via an explicit precedence | ||
| order. | ||
|
|
||
| Two skills consume it, and consume the *same* function so they can never | ||
| disagree: | ||
|
|
||
| - `pr-status-labeller` — writes `status:*` labels to GitHub. | ||
| - `pr-digest` — produces the read-only Mon/Wed/Fri Discord digest. | ||
|
|
||
| No LLM judgment lives here. All configuration (maintainer/labs handles, idle | ||
| thresholds, precedence order, managed label set) is at the top of `labels.py`; | ||
| edit it there and nowhere else. | ||
|
|
||
| Run standalone to inspect classification: | ||
|
|
||
| ```bash | ||
| python labels.py # human-readable table | ||
| python labels.py --json # structured output | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,332 @@ | ||
| # Copyright 2022 - 2026 The PyMC Labs Developers | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """Deterministic PR triage core for CausalPy. | ||
|
|
||
| Single source of truth for "what are the facts about each open PR". Both the | ||
| `pr-status-labeller` skill (writes `status:*` labels to GitHub) and the | ||
| `pr-digest` skill (Mon/Wed/Fri Discord digest) call this module so the two | ||
| never disagree. No LLM judgment lives here: everything is a pure function of | ||
| the GitHub API. The only judgment layer is the prose/framing the digest agent | ||
| adds on top of this structured output. | ||
|
|
||
| Usage: | ||
| python labels.py [--repo OWNER/NAME] [--json] | ||
|
|
||
| Requires the `gh` CLI authenticated with read access to the repo. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import argparse | ||
| import contextlib | ||
| import datetime as _dt | ||
| import json | ||
| import subprocess | ||
| import sys | ||
| from dataclasses import asdict, dataclass, field | ||
|
|
||
| # --- Configuration (edit here, nowhere else) -------------------------------- | ||
|
|
||
| DEFAULT_REPO = "pymc-labs/CausalPy" | ||
|
|
||
| # Author classification. Everyone not listed and not a bot is "external". | ||
| MAINTAINERS = {"drbenvincent"} | ||
| LABS = { | ||
| "NathanielF", | ||
| "juanitorduz", | ||
| "cetagostini", | ||
| "twiecki", | ||
| "ricardoV94", | ||
| "OriolAbril", | ||
| "daimon-pymclabs", # labs automation account (still bot-like, see BOT rule) | ||
| } | ||
|
|
||
| # Idle-band thresholds, in days. Confirmed with maintainer: | ||
| # nudge (aging) at 30d, stale warning at 90d. | ||
| AGING_DAYS = 30 | ||
| STALE_DAYS = 90 | ||
|
|
||
| # Precedence order for the single derived `next_action`. First match wins. | ||
| # This is the ONE place priority judgment is encoded; tune it here. | ||
| NEXT_ACTION_ORDER = [ | ||
| "decision", # needs a maintainer decision (the hard queue) | ||
| "stale-draft", # your own draft, idle >= STALE_DAYS | ||
| "aging-draft", # your own draft, idle >= AGING_DAYS | ||
| "in-flight-draft", # fresh draft, WIP, silent | ||
| "waiting-on-author", # changes requested, ball in author's court | ||
| "ready-to-merge", # approved + clean + not red | ||
| "mechanical", # conflicting or CI red (agent-fixable in Tier 2) | ||
| "ready-for-review", # clean, green/pending, awaiting a reviewer | ||
| ] | ||
|
|
||
| # Rank lookup so the CLI table and any consumer order by this list, not | ||
| # alphabetically. Editing NEXT_ACTION_ORDER above now actually reorders output. | ||
| NEXT_ACTION_RANK = {a: i for i, a in enumerate(NEXT_ACTION_ORDER)} | ||
|
|
||
| # The `status:*` labels the labeller is allowed to manage. It touches ONLY this | ||
| # namespace, never `review:*`, `major`, `needs:maintainer-decision`, etc. | ||
| STATUS_LABELS = { | ||
| "status:conflicting", | ||
| "status:ci-failing", | ||
| "status:waiting-on-author", | ||
| "status:ready-for-review", | ||
| "status:aging", | ||
| "status:stale", | ||
| } | ||
|
cursor[bot] marked this conversation as resolved.
|
||
|
|
||
| # ----------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| def _now() -> _dt.datetime: | ||
| return _dt.datetime.now(_dt.UTC) | ||
|
|
||
|
|
||
| def _parse_ts(ts: str) -> _dt.datetime: | ||
| return _dt.datetime.fromisoformat(ts) | ||
|
|
||
|
|
||
| def _days_since(ts: str) -> int: | ||
| return (_now() - _parse_ts(ts)).days | ||
|
|
||
|
|
||
| def _gh_json(args: list[str]) -> object: | ||
| out = subprocess.run( | ||
| ["gh", *args], capture_output=True, text=True, check=True | ||
| ).stdout | ||
| return json.loads(out) if out.strip() else None | ||
|
|
||
|
|
||
| def fetch_prs(repo: str) -> list[dict]: | ||
| """Fetch open PRs. Forces GitHub to compute the lazily-evaluated | ||
| `mergeable` field, which comes back UNKNOWN in bulk listings.""" | ||
| fields = ( | ||
| "number,title,author,isDraft,mergeable,reviewDecision," | ||
| "updatedAt,createdAt,labels,statusCheckRollup" | ||
| ) | ||
| prs = ( | ||
| _gh_json( | ||
| [ | ||
| "pr", | ||
| "list", | ||
| "--repo", | ||
| repo, | ||
| "--state", | ||
| "open", | ||
| "--limit", | ||
| "200", | ||
| "--json", | ||
| fields, | ||
| ] | ||
| ) | ||
| or [] | ||
| ) | ||
| # Poke each UNKNOWN mergeable once; `gh pr view` triggers the computation. | ||
| for pr in prs: | ||
| if pr.get("mergeable") == "UNKNOWN": | ||
| with contextlib.suppress(subprocess.CalledProcessError): | ||
| v = _gh_json( | ||
| [ | ||
| "pr", | ||
| "view", | ||
| str(pr["number"]), | ||
| "--repo", | ||
| repo, | ||
| "--json", | ||
| "mergeable", | ||
| ] | ||
| ) | ||
| if v: | ||
| pr["mergeable"] = v.get("mergeable", "UNKNOWN") | ||
|
cursor[bot] marked this conversation as resolved.
Outdated
|
||
| return prs | ||
|
|
||
|
|
||
| def _ci_state(pr: dict) -> str: | ||
| rollup = pr.get("statusCheckRollup") or [] | ||
| states = [c.get("conclusion") or c.get("state") for c in rollup] | ||
| if not states: | ||
| return "none" | ||
| bad = {"FAILURE", "ERROR", "TIMED_OUT", "CANCELLED", "ACTION_REQUIRED"} | ||
| if any(s in bad for s in states): | ||
| return "red" | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| pending = {"PENDING", "IN_PROGRESS", "QUEUED", "EXPECTED", None} | ||
| if any(s in pending for s in states): | ||
| return "pending" | ||
| return "green" | ||
|
cursor[bot] marked this conversation as resolved.
cursor[bot] marked this conversation as resolved.
|
||
|
|
||
|
|
||
| def _author_class(login: str) -> str: | ||
| if login in MAINTAINERS: | ||
| return "maintainer" | ||
| if "[bot]" in login or login.startswith("app/") or login.endswith("-pymclabs"): | ||
| return "bot" | ||
| if login in LABS: | ||
| return "labs" | ||
| return "external" | ||
|
|
||
|
|
||
| def _idle_band(idle: int) -> str: | ||
| if idle >= STALE_DAYS: | ||
| return "stale" | ||
| if idle >= AGING_DAYS: | ||
| return "aging" | ||
| return "fresh" | ||
|
|
||
|
|
||
| @dataclass | ||
| class PRFacts: | ||
| number: int | ||
| title: str | ||
| author: str | ||
| url: str | ||
| author_class: str | ||
| lifecycle: str # draft | ready | ||
| conflict: str # clean | conflicting | unknown | ||
| ci: str # green | red | pending | none | ||
| review: str # none | required | changes-requested | approved | ||
| decision_needed: bool | ||
| major: bool | ||
| risk: str | None # high | medium | low | None | ||
| idle_days: int | ||
| age_days: int | ||
| idle_band: str # fresh | aging | stale | ||
| next_action: str | ||
| status_labels: list[str] = field(default_factory=list) | ||
|
|
||
|
|
||
| def _review_state(reviewDecision: str | None) -> str: | ||
| return { | ||
| None: "none", | ||
| "REVIEW_REQUIRED": "required", | ||
| "CHANGES_REQUESTED": "changes-requested", | ||
| "APPROVED": "approved", | ||
| }.get(reviewDecision, "none") | ||
|
|
||
|
|
||
| def _next_action(f: dict) -> str: | ||
| draft = f["lifecycle"] == "draft" | ||
| if f["decision_needed"]: | ||
| return "decision" | ||
| if draft: | ||
| if f["idle_band"] == "stale": | ||
| return "stale-draft" | ||
| if f["idle_band"] == "aging": | ||
| return "aging-draft" | ||
| return "in-flight-draft" | ||
| if f["review"] == "changes-requested": | ||
| return "waiting-on-author" | ||
| if f["review"] == "approved" and f["conflict"] == "clean" and f["ci"] != "red": | ||
| return "ready-to-merge" | ||
| if f["conflict"] == "conflicting" or f["ci"] == "red": | ||
| return "mechanical" | ||
| return "ready-for-review" | ||
|
cursor[bot] marked this conversation as resolved.
|
||
|
|
||
|
|
||
| def _status_labels_for(f: dict) -> list[str]: | ||
| """Derive the `status:*` label set. Drafts stay out of the reviewer-facing | ||
| statuses; they only carry aging/stale flags.""" | ||
| labels: list[str] = [] | ||
| draft = f["lifecycle"] == "draft" | ||
| if f["idle_band"] == "stale": | ||
| labels.append("status:stale") | ||
| elif f["idle_band"] == "aging": | ||
| labels.append("status:aging") | ||
| if not draft: | ||
| if f["conflict"] == "conflicting": | ||
| labels.append("status:conflicting") | ||
| if f["ci"] == "red": | ||
| labels.append("status:ci-failing") | ||
| if f["review"] == "changes-requested": | ||
| labels.append("status:waiting-on-author") | ||
| if f["next_action"] == "ready-for-review": | ||
| labels.append("status:ready-for-review") | ||
| # Guard against drift: the labeller only manages the STATUS_LABELS set. | ||
| assert set(labels) <= STATUS_LABELS, ( | ||
| f"emitted labels {set(labels) - STATUS_LABELS} are outside STATUS_LABELS" | ||
| ) | ||
| return labels | ||
|
|
||
|
|
||
| def classify(prs: list[dict]) -> list[PRFacts]: | ||
| results: list[PRFacts] = [] | ||
| for pr in prs: | ||
| login = pr["author"]["login"] | ||
| names = [lab["name"] for lab in pr.get("labels", [])] | ||
| risk = next( | ||
| (n.split(":", 1)[1] for n in names if n.startswith("review:")), None | ||
| ) | ||
| merge = pr.get("mergeable", "UNKNOWN") | ||
| conflict = {"CONFLICTING": "conflicting", "MERGEABLE": "clean"}.get( | ||
| merge, "unknown" | ||
| ) | ||
| f = { | ||
| "number": pr["number"], | ||
| "title": pr["title"], | ||
| "author": login, | ||
| "url": f"https://github.com/{REPO}/pull/{pr['number']}", | ||
| "author_class": _author_class(login), | ||
| "lifecycle": "draft" if pr["isDraft"] else "ready", | ||
| "conflict": conflict, | ||
| "ci": _ci_state(pr), | ||
| "review": _review_state(pr.get("reviewDecision")), | ||
| "decision_needed": "needs:maintainer-decision" in names, | ||
| "major": "major" in names, | ||
| "risk": risk, | ||
| "idle_days": _days_since(pr["updatedAt"]), | ||
| "age_days": _days_since(pr["createdAt"]), | ||
| } | ||
| f["idle_band"] = _idle_band(f["idle_days"]) | ||
|
cursor[bot] marked this conversation as resolved.
Outdated
|
||
| f["next_action"] = _next_action(f) | ||
| f["status_labels"] = _status_labels_for(f) | ||
| results.append(PRFacts(**f)) | ||
| return results | ||
|
|
||
|
|
||
| REPO = DEFAULT_REPO | ||
|
|
||
|
|
||
| def main() -> int: | ||
| global REPO | ||
| ap = argparse.ArgumentParser(description=__doc__) | ||
| ap.add_argument("--repo", default=DEFAULT_REPO) | ||
| ap.add_argument("--json", action="store_true", help="emit JSON to stdout") | ||
| args = ap.parse_args() | ||
| REPO = args.repo | ||
| facts = classify(fetch_prs(REPO)) | ||
| payload = { | ||
| "repo": REPO, | ||
| "generated_at": _now().isoformat(), | ||
| "open_count": len(facts), | ||
| "prs": [asdict(f) for f in facts], | ||
| } | ||
| if args.json: | ||
| json.dump(payload, sys.stdout, indent=2) | ||
| print() | ||
| else: | ||
| for f in sorted( | ||
| facts, | ||
| key=lambda x: ( | ||
| NEXT_ACTION_RANK.get(x.next_action, len(NEXT_ACTION_ORDER)), | ||
| -x.idle_days, | ||
| ), | ||
| ): | ||
| print( | ||
| f"#{f.number:<5} {f.next_action:<18} idle{f.idle_days:>4}d " | ||
| f"{f.author_class:<10} {f.title[:55]}" | ||
| ) | ||
| print(f"\n{len(facts)} open PRs") | ||
| return 0 | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main()) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.