Refuse wheel installs through directory symlinks and replace file symlinks - #14296
Open
notatallshaw wants to merge 3 commits into
Open
notatallshaw wants to merge 3 commits into
notatallshaw wants to merge 3 commits into
Conversation
notatallshaw
force-pushed
the
fix/wheel-install-symlink-escape
branch
from
September 5, 2026 02:33
f877675 to
67993ef
Compare
notatallshaw
force-pushed
the
fix/wheel-install-symlink-escape
branch
from
September 5, 2026 02:36
67993ef to
7ee6579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When pip writes a file, it follows any symlink already at that path, and a dangling symlink at a path pip is about to create is followed too. So a written file can land wherever the link points: wheel members, console scripts,
REQUESTED,pip downloadandpip wheeloutput, and the--targetcopy across filesystems.Fixes:
__pycache__is refused the same way.PR Checklist:
Used Claude and Codex to do multiple rounds of checking for completeness and correctness.