Conversation
pypa#694 added the option and a news entry but not the reference page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019zkQEGBfqqomF5tanu383Q
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
=======================================
Coverage 63.45% 63.45%
=======================================
Files 15 15
Lines 1267 1267
=======================================
Hits 804 804
Misses 463 463 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
agronholm
reviewed
Sep 16, 2026
agronholm
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The only thing that caught my eye is that last part about passing an empty string. The --build-number option works the same way, and that doesn't have any matching text there. This feels odd, and maybe we should fix both for the sake of consistency. Also, perhaps it would be good to explain how to pass an empty string on the command line?
Contributor
|
And yes, I would accept another PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wheel pack --helplists--local-version;docs/reference/wheel_pack.rstdoes not. #694 added the option and a news entry, but never touched the reference page.Checked the wording against the behaviour:
--local-version=foogivesdemo-1.0+foo-py3-none-any.whl,--local-version=""givesdemo-1.0-py3-none-any.whl. Docs build adds no new warning;pytest74 passed.Not bundled, happy to send separately:
wheel_convert.rstomits-v/--verbose, and its failure example shows an error string the command cannot actually produce — but which output you'd rather document there is your call, not mine.