Skip to content

Fix French decimal separator and apply to naturalsize#357

Closed
SpiliosDimakopoulos wants to merge 1 commit into
python-humanize:mainfrom
SpiliosDimakopoulos:fix-51-naturalsize-french-decimal
Closed

Fix French decimal separator and apply to naturalsize#357
SpiliosDimakopoulos wants to merge 1 commit into
python-humanize:mainfrom
SpiliosDimakopoulos:fix-51-naturalsize-french-decimal

Conversation

@SpiliosDimakopoulos

@SpiliosDimakopoulos SpiliosDimakopoulos commented Jul 23, 2026

Copy link
Copy Markdown

Re: #51

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.56%. Comparing base (c3a124c) to head (9190d01).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          12       12           
  Lines         913      915    +2     
=======================================
+ Hits          909      911    +2     
  Misses          4        4           
Flag Coverage Δ
macos-latest 97.59% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 97.59% <100.00%> (+<0.01%) ⬆️
windows-latest 95.73% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jul 23, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.29%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 14 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_naturalsize 62.1 µs 69.2 µs -10.29%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing SpiliosDimakopoulos:fix-51-naturalsize-french-decimal (9190d01) with main (c3a124c)

Open in CodSpeed

@hugovk hugovk added the changelog: Fixed For any bug fixes label Jul 23, 2026
@hugovk

hugovk commented Jul 23, 2026

Copy link
Copy Markdown
Member

The decimal separator was set to . in #248, although https://en.wikipedia.org/wiki/Decimal_separator#Countries_using_decimal_comma says France and Canada (when using French) use ,

@merwok Shall we use , for French?

@hugovk hugovk changed the title Fix French decimal separator and apply it to naturalsize (#51) Fix French decimal separator and apply it to naturalsize Jul 23, 2026
@hugovk hugovk changed the title Fix French decimal separator and apply it to naturalsize Fix French decimal separator and apply to naturalsize Jul 23, 2026
@SpiliosDimakopoulos SpiliosDimakopoulos closed this by deleting the head repository Jul 23, 2026
@hugovk

hugovk commented Jul 23, 2026

Copy link
Copy Markdown
Member

@SpiliosDimakopoulos Why did you close this?

@merwok

merwok commented Jul 23, 2026

Copy link
Copy Markdown

Definitely need , for fr_FR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Fixed For any bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants