Fix Metop-SG-A1 to Metop-SGA1 naming scheme

[djhoese]

Also add entries for D/E/F in the hopes that the spacecraft global attribute will be changed when the instrument is operational.

• Closes #xxxx
• Tests added
• Fully documented
• Add your name to AUTHORS.md if not there already

[adybbroe]

https://space.oscar.wmo.int/satellites/view/metop_sg_a1
Should we not follow Oscar here?
I think we have the Oscar style for Pyspectral, so wouldn't this break it for Pyspectral?

[djhoese]

I've submitted a request to Oscar to rename them. EUMETSAT officials have complained to @ameraner and some of my SSEC colleagues to use the naming in this PR. Oscar is wrong as far as following the spacecraft organization's standards (EUMETSAT).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (d2ee98f) to head (19dbf96).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3448   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         465      465           
  Lines       59151    59151           
=======================================
  Hits        56990    56990           
  Misses       2161     2161           

Flag	Coverage Δ
behaviourtests	3.58% <0.00%> (ø)
unittests	96.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[strandgren]

I wouldn't bee too optimistic about anything changing in the format specification and file attributes once the satellite becomes operational, I suspect it will stay as now to be honest.

Also note that we have the Metop-SG-B satellites as well, carrying mainly instruments operating the microwave range. Since the two sets of satellites are launched in turns, I think the final operational names will become something like this:

Metop-SG-A1 -> Metop-D
Metop-SG-B1 -> Metop-E
Metop-SG-A2 -> Metop-F
Metop-SG-B2 -> Metop-G
Metop-SG-A3 -> Metop-H
Metop-SG-B3 -> Metop-I

but depending on the exact launch sequence and in which order the satellites are declared operational.

[ameraner]

I don't think that the filename/content will change once the spacecraft is operational either, so we'll probably never hit the new dict entries, but instead we'll have to update the dict value (I know, painful).

Honestly, I would propose to leave things as-is and not merge this, until the spacecraft goes operational. Otherwise we probably have to adapt pyspectral twice again. And Oscar, as of now, still agrees with satpy.

[djhoese]

Thanks everyone for the feedback. This is exactly why I created this PR; to better my understanding.

Honestly, I would propose to leave things as-is and not merge this, until the spacecraft goes operational. Otherwise we probably have to adapt pyspectral twice again. And Oscar, as of now, still agrees with satpy.

@ameraner @strandgren Let's say Oscar gets back to me with "yes, you're right, we'll change that right away". After it is changed, do you think that it'd still be better to wait for the operational change to SGA1/D to make changes here in satpy and in pyspectral?

[strandgren]

I think staying aligned with Oscar is a good idea. So for now keep as is, but if OSCAR do change the name, we should change satpy and pyspectral as well.

And as long as WMO OSACR is "wrong" I don't think it's fair by EUMETSAT to complain about the naming.