Skip to content

Add file type for OMPS total SO2 (V8TOS) in omps_edr reader - #3455

Merged
djhoese merged 2 commits into
pytroll:mainfrom
djhoese:feat-omps-so2
Sep 2, 2026
Merged

Add file type for OMPS total SO2 (V8TOS) in omps_edr reader#3455
djhoese merged 2 commits into
pytroll:mainfrom
djhoese:feat-omps-so2

Conversation

@djhoese

@djhoese djhoese commented Sep 2, 2026

Copy link
Copy Markdown
Member

This PR adds support for the SO2 EDR files for the OMPS reader (omps_edr). The basic functionality was easy to add, but getting filtering to do something useful and remove noise took some time. There were differences between what the file says to do: _FillValue/valid_ragne versus other non-CF values versus what the algorithm developer said should be done versus what was actually done on the JSTAR Mapper website to get the data prepared for visualization. More detailed discussion can be found in the Polar2Grid issue related to this (ssec/polar2grid#820). What we landed on was something in between what the algorithm developer said to do and what JSTAR Mapper was doing with IDL code. The basic idea is that there is an ErrorFlag variable that can be used for basic quality filtering but for SO2 variables it seems to do very little. The other filtering option is to remove any negative values from the SO2 column amount fields. JSTAR Mapper chooses to remove anything below 1, but we didn't quite agree with remove real values between 0 and 1. Both these types of filtering are off by default in Satpy (we'll the negative filter on by default in P2G).

This PR also rewrites some of the tests for this reader as Claude discovered some inconsistencies with real files and between the Ozone files and the SO2 files.

CC @kathys

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese self-assigned this Sep 2, 2026
@djhoese
djhoese requested a review from mraspaud as a code owner September 2, 2026 13:48
@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Sep 2, 2026
@djhoese djhoese changed the title Add file type for omps total so2 in omps_edr reader Add file type for OMPS total so2 in omps_edr reader Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.42520% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.35%. Comparing base (17bf08d) to head (07d9bcf).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/omps_edr.py 92.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3455    +/-   ##
========================================
  Coverage   96.34%   96.35%            
========================================
  Files         465      465            
  Lines       59151    59327   +176     
========================================
+ Hits        56990    57163   +173     
- Misses       2161     2164     +3     
Flag Coverage Δ
behaviourtests 3.57% <0.00%> (-0.02%) ⬇️
unittests 96.44% <98.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djhoese djhoese changed the title Add file type for OMPS total so2 in omps_edr reader Add file type for OMPS total SO2 (V8TOS) in omps_edr reader Sep 2, 2026
@djhoese
djhoese merged commit d32cb30 into pytroll:main Sep 2, 2026
17 of 18 checks passed
@djhoese
djhoese deleted the feat-omps-so2 branch September 2, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:readers enhancement code enhancements, features, improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant