Add file type for OMPS total SO2 (V8TOS) in omps_edr reader - #3455
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3455 +/- ##
========================================
Coverage 96.34% 96.35%
========================================
Files 465 465
Lines 59151 59327 +176
========================================
+ Hits 56990 57163 +173
- Misses 2161 2164 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
djhoese
force-pushed
the
feat-omps-so2
branch
from
September 2, 2026 14:06
3ac4e26 to
07d9bcf
Compare
omps_edr reader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the SO2 EDR files for the OMPS reader (
omps_edr). The basic functionality was easy to add, but getting filtering to do something useful and remove noise took some time. There were differences between what the file says to do: _FillValue/valid_ragne versus other non-CF values versus what the algorithm developer said should be done versus what was actually done on the JSTAR Mapper website to get the data prepared for visualization. More detailed discussion can be found in the Polar2Grid issue related to this (ssec/polar2grid#820). What we landed on was something in between what the algorithm developer said to do and what JSTAR Mapper was doing with IDL code. The basic idea is that there is anErrorFlagvariable that can be used for basic quality filtering but for SO2 variables it seems to do very little. The other filtering option is to remove any negative values from the SO2 column amount fields. JSTAR Mapper chooses to remove anything below 1, but we didn't quite agree with remove real values between 0 and 1. Both these types of filtering are off by default in Satpy (we'll the negative filter on by default in P2G).This PR also rewrites some of the tests for this reader as Claude discovered some inconsistencies with real files and between the Ozone files and the SO2 files.
CC @kathys
AUTHORS.mdif not there already