Fix Windows clang++ CI failure in maxpos sample by guarding CRT deprecation warnings - #1
Draft
LLaammTTeerr with Copilot wants to merge 2 commits into
Draft
Fix Windows clang++ CI failure in maxpos sample by guarding CRT deprecation warnings#1LLaammTTeerr with Copilot wants to merge 2 commits into
LLaammTTeerr with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Use clang++ on windows-2022
Fix Windows clang++ CI failure in maxpos sample by guarding CRT deprecation warnings
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Use clang++ on windows-2022job failed during the compile sweep becausedocs/examples/maxpos/sol-correct.cppusesscanf, which is treated as deprecated under MSVC CRT and escalated by-Werror. This change removes that toolchain-specific failure without changing runtime behavior.Root cause
scanfinsol-correct.cpp; CI compiles with warnings-as-errors.Change
docs/examples/maxpos/sol-correct.cpp:_CRT_SECURE_NO_WARNINGSbefore including<cstdio>Behavioral impact