Now you can submit pressing shift+enter - #110
Conversation
| if (event.charCode === 13 && event.shiftKey) { | ||
| this.save(); | ||
| this.onEscape(event); | ||
| } |
There was a problem hiding this comment.
if and else do the same action (this.save() and this.onEscape(event)) then is not necessary if-else. You would rethink the condition using an OR operator maybe.
If you have problems with this logic, contact me and can rethink together.
Caballerog
left a comment
Caballerog
left a comment
There was a problem hiding this comment.
if and else do the same action (this.save() and this.onEscape(event)) then is not necessary if-else. You would rethink the condition using an OR operator maybe.
If you have problems with this logic, contact me and can rethink together.
…arent from method
Caballerog
left a comment
Caballerog
left a comment
There was a problem hiding this comment.
(A && B && !C) || (!A && B && C)
What's the common factor? ;-)
| super.onKeyPress(event); | ||
| if ((this.config.saveOnEnter && event.charCode === 13 && !event.shiftKey) || | ||
| (!this.config.saveOnEnter && event.charCode === 13 && event.shiftKey)) { | ||
| this.save(); |
There was a problem hiding this comment.
(A && B && !C) || (!A && B && C)
What's the common factor? ;-)
|
@xxxtonixxx, any chance of merging the pull request? Thanks! |
3 participants
#93